-
Notifications
You must be signed in to change notification settings - Fork 194
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[tooltip] Bikeshed the name for a popovertargetaction
value to hover/focus trigger
#767
Comments
Some other values that come to mind (not that I think they're better, but just brainstorming):
One thing we might need to take account, is that some devs might want to trigger a popover on toggle for mobile devices and use the hover/focus state on the desktop versions. Although that a focus state kind of feels the same, so I guess that will be good enough for this? |
thumb up for popovertargetaction=interest Waht more |
The Open UI Community Group just discussed The full IRC log of that discussion<gregwhitworth> Topic: [tooltip] Bikeshed the name for a popovertargetaction value to hover/focus trigger<gregwhitworth> github: https://github.com//issues/767 <hdv> masonf: I just wrote an explainer for this, working on popover=hint and triggering additions that we had in the original proposal <hdv> masonf: this is one of the new things, we need to add a new value to popover that indicates that the popover should be triggered when the element is hovered, keyboard focused and long pressed on mobile <gregwhitworth> q? <hdv> masonf: would be best if we had a word that encompasses all of those things <hdv> s/a//one <hdv> s//one/one <hdv> masonf: one use case is a popover that triggers something when you hover and something slightly different when you click <hdv> masonf: a related issue, at the WHATWG repo, is an attribute that would allow declarative setting up of triggering modal dialogs <hdv> gregwhitworth: were there any names you wanted to propose? <hdv> masonf: there is a list on the issue, several lists actually <dbaron> related whatwg issue mason mentioned is https://github.com/whatwg/html/pull/9456 <hdv> masonf: hover, over, active, interest, indeterminate, hint, float… there is a bunch <hdv> gregwhitworth: folks, if you have any other names, go to the issue <gregwhitworth> q? <hdv> annevk: one thing I wanted to note… there is also other proposals for new button attributes, like dialogmodaltarget, which might feel like something similar, maybe we should spend more time to figure out what a more generic mechanism would be like <hdv> annevk: maybe you would also want to dismiss or toggle a dialog <hdv> annevk: especially if there might be other things we want to target in the future, we might want something more generic… the thing you want to target, the action you want it to trigger on and the reason you want the action… we probably want to avoid having dozens of attributes in the future <hdv> ntim: if we have multiple declarative attributes, it is also unclear which one takes precedence <hdv> gregwhitworth: maybe we can action you, masonf, to summarise this discussion in 9456? <hdv> masonf: maybe even agenda+ 9456 here? <hdv> scotto: yes agree we should want to discuss this more holistically <hdv> scotto: there could be all sorts of scenarios we probably want to avoid, like opening a modal dialog on hover <gregwhitworth> ACTION: masonf to sum up in a comment the relationship with 9456 and annek and bring back to the group when there is something to resolve against |
linking this mentioned as related/relevant so that you don't have to drill into minutes to find it: whatwg/html#9456 |
So quick summary of the discussion above:
|
I'll put some opinions down on the proposed options, hopefully useful (and hopefully informative for those just landing on this discussion). The TLDR is, in my humble opinion, that
|
Ok, please see the very nice summary above. But let's vote:
Please use the emoji button on Github that relates to the option you'd like to vote. Please vote only once. |
(Not to derail but we could use a poll) |
Cool! Guess I should have known about that feature. Let’s let this one go as-is since there are already votes. But next time for sure - that’s a lot easier than trying to find the correct “meh” face for the poll. |
The Open UI Community Group just discussed
The full IRC log of that discussion<gregwhitworth> Topic: popovertarget action naming bikeshed<gregwhitworth> github: https://github.com//issues/767#issuecomment-1634801385 <hdv> masonf: this is about adding a new trigger for popovers <hdv> masonf: Keith has gone through the different naming options, which was great <gregwhitworth> q? <hdv> masonf: the advantage of the current runner up, `popovertargetaction=interest`, is that 'interest' does not exist <hdv> q+ <gregwhitworth> ack hdv <masonf> Proposed resolution: Use popovertargetaction=interest. <gregwhitworth> hdv: wanted to +1 the list that kieth made was really useful and I like interest <masonf> RESOLVED: Use popovertargetaction=interest. <hdv> s/exist/exist as a thing in CSS yet (like active and focus0 |
Per the resolution: - [OpenUI: Resolution to use `interest` as the name of the value](openui#767 (comment)) This also updates the articles and references section to include that, and adds a bit more text explaining the new name.
* Rename `hover` to `interest` Per the resolution: - [OpenUI: Resolution to use `interest` as the name of the value](#767 (comment)) This also updates the articles and references section to include that, and adds a bit more text explaining the new name. * Sentence tweak --------- Co-authored-by: Mason Freed <[email protected]>
See this discussion, but the current proposal is to do "hover triggering" via a new value for the
popovertargetaction
attribute:However, "hover" triggering doesn't tell the whole story, since keyboard users need focus to trigger the popover, and touch users need long press to trigger it. So the question is: what should this value be called?
Here are some ideas I've heard, please feel free to add more:
popovertargetaction=hover
popovertargetaction=over
popovertargetaction=active
popovertargetaction=interest
The text was updated successfully, but these errors were encountered: