BINDINGS/GO/PERF: Implement flag.Value for UcsMemoryType #10312
+48
−14
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tvegas1
previously approved these changes
Nov 21, 2024
bindings/go/src/ucx/memory.go
Outdated
| switch strings.ToLower(value) { | ||
| case "host": *mt = UCS_MEMORY_TYPE_HOST | ||
| case "cuda": *mt = UCS_MEMORY_TYPE_CUDA | ||
| default: return errors.New("memory type can be host or cuda") |
yosefe
reviewed
Nov 21, 2024
bindings/go/src/ucx/memory.go
Outdated
| @@ -67,3 +72,12 @@ func (m *UcpMemory) Close() error { | |||
|
|
|||
| return nil | |||
| } | |||
|
|
|||
| func (mt *UcsMemoryType) Set (value string) error { | |||
There was a problem hiding this comment.
does it mean that ucx go bindings set memory type by string instead of value?
IMO string->Value logic should be in perftest, not in go bindings.
There was a problem hiding this comment.
in golang interface can't be implemented on type from other package, though may created wrapper for mem type in perftest
on the other hand value -> string logic already implemented in go bindings,
ucx/bindings/go/src/ucx/ucs_constants.go
Line 33 in 7195d04
yosefe
reviewed
Nov 24, 2024
yosefe
reviewed
Nov 24, 2024
bindings/go/src/ucx/ucs_constants.h
Outdated
Comment on lines
12
to
19
| static inline const char* ucxgo_get_ucs_mem_type_name(ucs_memory_type_t idx) { | ||
| return ucs_memory_type_names[idx]; | ||
| } | ||
|
|
||
| static inline ssize_t ucxgo_parse_ucs_mem_type_name(void* value) { | ||
| ssize_t idx = ucs_string_find_in_list((const char *)value, ucs_memory_type_names, 0); | ||
| free(value); | ||
| return idx; |
There was a problem hiding this comment.
do these functions have to be inline?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Implement
flag.Valueinterface forucx.UcsMemoryTypeand useflag.Varfunction to set-margument.Why?
For enums,
flag.Value/flag.Varis the better choice because it promotes good software design principles like type safety, reusability, and clean separation of concerns.