CI: Convert Python2 testing scripts to Python3 #10290
Open
+41
−44
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Alexey-Rivkin
force-pushed
the
topic/python_2to3
branch
from
313e5ea
to
c32d4d4
Compare
Alexey-Rivkin
force-pushed
the
topic/python_2to3
branch
from
c32d4d4
to
981074c
Compare
dpressle
suggested changes
Nov 12, 2024
test/apps/test_fuzzy_match.py
Outdated
There was a problem hiding this comment.
Do we want to also fix the shebang to python3 and not be dependent on default python settings?
gleon99
reviewed
Nov 13, 2024
test/apps/test_ucx_tls.py
Outdated
| if options.verbose: | ||
| print "return code " + str(status) | ||
| print output | ||
| print("return code " + str(status)) |
There was a problem hiding this comment.
Maybe use f-string instead?
dpressle
suggested changes
Nov 17, 2024
There was a problem hiding this comment.
Sure, thanks!
Alexey-Rivkin
force-pushed
the
topic/python_2to3
branch
from
d7ca501
to
409480d
Compare
Alexey-Rivkin
force-pushed
the
topic/python_2to3
branch
from
8bca42e
to
06e3f08
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Convert Python2 testing scripts to Python3.
Why?
We missed the Python2 EOL date a bit (Jan 1, 2020).