UCT/CUDA_IPC: Increase MAX_PEERS and MAX_STREAMS #10258
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yosefe
reviewed
Oct 27, 2024
| @@ -30,7 +30,7 @@ static ucs_config_field_t uct_cuda_ipc_iface_config_table[] = { | |||
| "Max number of event completions to pick during cuda events polling", | |||
| ucs_offsetof(uct_cuda_ipc_iface_config_t, max_poll), UCS_CONFIG_TYPE_UINT}, | |||
|
|
|||
| {"MAX_STREAMS", "16", | |||
| {"MAX_STREAMS", "128", | |||
There was a problem hiding this comment.
can we use UCS_PP_MAKE_STRING(UCT_CUDA_IPC_MAX_PEERS) here?
what happens if the user sets MAX_STREAMS config to a value larger than UCT_CUDA_IPC_MAX_PEERS?
There was a problem hiding this comment.
Having larger MAX_STREAMS than UCT_CUDA_IPC_MAX_PEERS allows cuda-ipc transport to round-robin select among more number of streams. It wouldn't be a functional or performance issue in my opinion although it is unlikely to improve performance.
brminich
approved these changes
Nov 20, 2024
yosefe
approved these changes
Nov 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why ?
Need this ensure greater concurrency for a larger count of peers reachable by cuda_ipc.