Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix unannotated fall-through between switch labels in utils/ucc_coll_utils.h #984

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

bunnypak
Copy link

What

fix unannotated fall-through between switch labels in utils/ucc_coll_utils.h

Why ?

When building on x86_64 Linux and clang 15,

...
utils/ucc_coll_utils.h:291:5: error: unannotated fall-through between switch labels [-Werror,-Wimplicit-fallthrough]
    default:
    ^
...

@swx-jenkins3
Copy link

Can one of the admins verify this patch?

@Sergei-Lebedev
Copy link
Contributor

ok to test

@Sergei-Lebedev Sergei-Lebedev requested a review from manjugv June 11, 2024 06:21
@manjugv
Copy link
Contributor

manjugv commented Jun 12, 2024

@bunnypak What is your affiliation? have you or your institution signed CLA?

@manjugv
Copy link
Contributor

manjugv commented Jun 12, 2024

@bunnypak What is your affiliation? have you or your institution signed CLA?

@bunnypak What is your affiliation? have you or your institution signed CLA?

https://github.com/openucx/ucc?tab=readme-ov-file#contributing

@bunnypak
Copy link
Author

@bunnypak What is your affiliation? have you or your institution signed CLA?

Meta. Personally no. Not sure about my institution.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants