-
Notifications
You must be signed in to change notification settings - Fork 103
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CL/HIER: Add allgatherv #1050
Open
nsarka
wants to merge
2
commits into
openucx:master
Choose a base branch
from
nsarka:nsarka/cl-hier-allgatherv
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
CL/HIER: Add allgatherv #1050
+688
−44
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nsarka
force-pushed
the
nsarka/cl-hier-allgatherv
branch
from
December 2, 2024 15:32
9e34573
to
c126e93
Compare
nsarka
force-pushed
the
nsarka/cl-hier-allgatherv
branch
2 times, most recently
from
December 2, 2024 15:46
198da51
to
862cad6
Compare
Closed
nsarka
commented
Dec 4, 2024
nsarka
commented
Dec 4, 2024
nsarka
commented
Dec 4, 2024
nsarka
commented
Dec 4, 2024
nsarka
commented
Dec 4, 2024
nsarka
commented
Dec 4, 2024
nsarka
commented
Dec 4, 2024
nsarka
force-pushed
the
nsarka/cl-hier-allgatherv
branch
2 times, most recently
from
December 6, 2024 22:23
0774618
to
1298163
Compare
Can one of the admins verify this patch? |
@aamirshafi Please review |
nsarka
force-pushed
the
nsarka/cl-hier-allgatherv
branch
from
December 13, 2024 21:53
584b1b4
to
0305f14
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds CL/HIER allgatherv and updates the allgatherv gtest to test non-contiguous dst buffers. It is meant to be used in conjunction with my TL/SHM gatherv implementation.
The algorithm is:
Comparison Data
2 nodes, 32 PPN on lego-grace cg (1 socket, 72 cores/socket)