TL/UCP: use knomial pattern in gather #1044
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@aamirshafi Did you have any comments? |
aamirshafi
reviewed
Nov 27, 2024
aamirshafi
reviewed
Nov 27, 2024
aamirshafi
reviewed
Nov 27, 2024
aamirshafi
suggested changes
Nov 27, 2024
There was a problem hiding this comment.
@Sergei-Lebedev presented this PR in couple of sessions. I have requested a few changes that are inserted as comments: 1) clarify the structure of header files (recursive_knomial.h and sra_knomial.h), and 2) add a few comments to explain corner-cases.
I have added my review @manjugv. |
samnordmann
approved these changes
Dec 4, 2024
Sergei-Lebedev
force-pushed
the
topic/gather_kn_pattern
branch
from
95009fe to
f3443c2
Compare
|
Can one of the admins verify this patch? |
Sergei-Lebedev
commented
Dec 11, 2024
|
@manjugv - this PR looks good to me. |
janjust
approved these changes
Dec 12, 2024
Sergei-Lebedev
force-pushed
the
topic/gather_kn_pattern
branch
from
f3443c2 to
1f2ba86
Compare
andylin-hao
pushed a commit
to andylin-hao/ucc
that referenced
this pull request
Dec 26, 2024
* TL/UCP: use knomial pattern in gather * REVIEW: fix review comments
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Use knomial pattern data structure in gather knomial algorithm in TL UCP
Why ?
part of #1035
_