minor fixes

openucx · Dec 22, 2024 · 5619791 · 5619791
1 parent d7a97ce
commit 5619791
Show file tree

Hide file tree

Showing 6 changed files with 4 additions and 8 deletions.
diff --git a/src/components/tl/ucp/allgather/allgather.c b/src/components/tl/ucp/allgather/allgather.c
@@ -74,4 +74,4 @@ ucc_status_t loopback_self_copy(void* rbuf, void* sbuf, size_t data_size,
         return task->super.status;
     }
     return UCC_OK;
-}
+}
diff --git a/src/components/tl/ucp/allgather/allgather_knomial.c b/src/components/tl/ucp/allgather/allgather_knomial.c
@@ -87,7 +87,6 @@ void ucc_tl_ucp_allgather_knomial_progress(ucc_coll_task_t *coll_task)
     } else {
         EXEC_TASK_TEST(UCC_KN_PHASE_INIT, "failed during ee task test", task->allgather_kn.etask);
     }
-
     task->allgather_kn.etask = NULL;
     UCC_KN_GOTO_PHASE(task->allgather_kn.phase);
     if (KN_NODE_EXTRA == node_type) {

diff --git a/src/components/tl/ucp/allgather/allgather_neighbor.c b/src/components/tl/ucp/allgather/allgather_neighbor.c
@@ -145,7 +145,7 @@ ucc_status_t ucc_tl_ucp_allgather_neighbor_start(ucc_coll_task_t *coll_task)
     ucc_status_t       status;
     ucc_rank_t         neighbor;
     void              *tmprecv, *tmpsend;
-    
+
     UCC_TL_UCP_PROFILE_REQUEST_EVENT(coll_task, "ucp_allgather_neighbor_start",
                                      0);
     ucc_tl_ucp_task_reset(task, UCC_INPROGRESS);

diff --git a/src/components/tl/ucp/allgather/allgather_ring.c b/src/components/tl/ucp/allgather/allgather_ring.c
@@ -53,7 +53,6 @@ void ucc_tl_ucp_allgather_ring_progress(ucc_coll_task_t *coll_task)
     step = use_loopback ? task->tagged.send_posted - 1 : task->tagged.send_posted;
 
     while (step < tsize - 1) {
-
         sblock = task->allgather_ring.get_send_block(&task->subset, trank,
                                                      tsize, step);
         rblock = task->allgather_ring.get_recv_block(&task->subset, trank,
@@ -66,12 +65,10 @@ void ucc_tl_ucp_allgather_ring_progress(ucc_coll_task_t *coll_task)
         UCPCHECK_GOTO(
             ucc_tl_ucp_recv_nb(buf, data_size, rmem, recvfrom, team, task),
             task, out);
-
         if (UCC_INPROGRESS == ucc_tl_ucp_test(task)) {
             return;
         }
         step = use_loopback ? task->tagged.send_posted - 1 : task->tagged.send_posted;
-        printf("debug :)'\n");
     }
     ucc_assert(UCC_TL_UCP_TASK_P2P_COMPLETE(task));
     task->super.status = UCC_OK;

diff --git a/src/components/tl/ucp/allgather/allgather_sparbit.c b/src/components/tl/ucp/allgather/allgather_sparbit.c
@@ -124,7 +124,7 @@ ucc_status_t ucc_tl_ucp_allgather_sparbit_start(ucc_coll_task_t *coll_task)
     size_t             data_size    = (count / tsize) * ucc_dt_size(dt);
     int                use_loopback = UCC_TL_UCP_TEAM_LIB(team)->cfg.allgather_use_loopback;
     ucc_status_t       status;
-    
+
     UCC_TL_UCP_PROFILE_REQUEST_EVENT(coll_task, "ucp_allgather_sparbit_start",
                                      0);
     ucc_tl_ucp_task_reset(task, UCC_INPROGRESS);

diff --git a/src/components/tl/ucp/tl_ucp.c b/src/components/tl/ucp/tl_ucp.c
@@ -140,7 +140,7 @@ ucc_config_field_t ucc_tl_ucp_lib_config_table[] = {
      ucc_offsetof(ucc_tl_ucp_lib_config_t, allgather_kn_radix),
      UCC_CONFIG_TYPE_UINT},
 
-     {"ALLGATHER_USE_LOOPBACK", "0", "If set to 1 uses mc cuda copy, otherwise performs loopback for self copy",
+    {"ALLGATHER_USE_LOOPBACK", "0", "If set to 1 performs network loopback for self copy, otherwise uses mc cuda copy",
      ucc_offsetof(ucc_tl_ucp_lib_config_t, allgather_use_loopback),
      UCC_CONFIG_TYPE_BOOL},
-Original file line number
+Diff line change
@@ Expand Up @@
             return task->super.status;
         }
         return UCC_OK;
-    }
+    }