Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(itinerary-body): grab mapillary URLs instead of just ID #401

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

fix(itinerary-body): grab mapillary URLs instead of just ID #401

wants to merge 1 commit into from

Conversation

miles-grant-ibigroup
Copy link
Collaborator

Using the ID was nice to be able to render the iframe with, but the Mapillary iframe does not work with chrome.

This PR adjusts the Mapillary fetch to return an image URL instead.

@miles-grant-ibigroup miles-grant-ibigroup mentioned this pull request May 11, 2022
Open
daniel-heppner-ibigroup
daniel-heppner-ibigroup approved these changes May 17, 2022
View reviewed changes
Copy link
Contributor

@daniel-heppner-ibigroup daniel-heppner-ibigroup left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:/

@miles-grant-ibigroup miles-grant-ibigroup removed their assignment May 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@daniel-heppner-ibigroup daniel-heppner-ibigroup daniel-heppner-ibigroup approved these changes

Assignees
No one assigned
Labels
on hold
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@miles-grant-ibigroup @daniel-heppner-ibigroup