Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use GH stars as a ranking factor #248

Merged
merged 7 commits into from
Dec 2, 2024
Merged

Use GH stars as a ranking factor #248

merged 7 commits into from
Dec 2, 2024

Conversation

abstractionfactory
Copy link
Collaborator

Checklist

  • I have read the contribution guide.
  • I have not used an AI coding assistant to create this PR.
  • My contribution is compatible with the MPL-2.0 license and I have provided a DCO sign-off on all my commits.
  • I have written all code in this PR myself OR I have marked all code I have not written myself (including modified code, e.g. copied from other places and then modified) with a comment indicating where it came from.

@cloudflare-workers-and-pages Cloudflare Workers and Pages
Copy link

cloudflare-workers-and-pages bot commented Nov 26, 2024 •
edited
Loading

Deploying registry-ui with  Cloudflare Pages  Cloudflare Pages

Latest commit: 4cf28a5
Status: ✅  Deploy successful!
Preview URL: https://1376a29c.registry-ui-dxi.pages.dev
Branch Preview URL: https://fix-ranking.registry-ui-dxi.pages.dev

View logs

@abstractionfactory abstractionfactory marked this pull request as draft November 28, 2024 09:17
@abstractionfactory abstractionfactory changed the title Draft: fixing search ranking Use GH stars as a ranking factor Nov 28, 2024
@abstractionfactory abstractionfactory linked an issue Dec 2, 2024 that may be closed by this pull request
Incorrect search ranking #250
Open
@abstractionfactory abstractionfactory marked this pull request as ready for review December 2, 2024 14:31
@abstractionfactory
Draft: fixing search ranking
074d8b3 
Signed-off-by: AbstractionFactory <[email protected]>
@abstractionfactory
Minor improvements
d7f5451 
Signed-off-by: AbstractionFactory <[email protected]>
@abstractionfactory
Adding warnings and popularity count
eb50abc 
Signed-off-by: AbstractionFactory <[email protected]>

# Conflicts:
#	backend/internal/providerindex/providertypes/provider.go
@abstractionfactory
Popularity wired through
9e55542 
Signed-off-by: AbstractionFactory <[email protected]>
@abstractionfactory
Index item comparison fix
7df3dc6 
Signed-off-by: AbstractionFactory <[email protected]>
@abstractionfactory
Addressing review comments
e73a8f5 
Signed-off-by: AbstractionFactory <[email protected]>
@abstractionfactory
Fixed upstream repo info
4cf28a5 
Signed-off-by: AbstractionFactory <[email protected]>
@abstractionfactory abstractionfactory merged commit 9bddf61 into main Dec 2, 2024
4 checks passed
@abstractionfactory abstractionfactory deleted the fix-ranking branch December 2, 2024 15:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cam72cam cam72cam cam72cam approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Incorrect search ranking
2 participants
@abstractionfactory @cam72cam