Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove usage of Algolia and Telemetry #7

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

Evi1Pumpkin
Copy link
Collaborator

  1. Telemetry was off by default, but I removed it altogether.
  2. Algolia was used to get auto-completion for module names from the registry. This specific auto-completion happened when you were in the module block inside the source attribute. Because we don't have an Algolia instance for OpenTofu this feature will be disabled. Auto-completion options will only support local modules. I'll open a ticket to trace this gap.

@Evi1Pumpkin Evi1Pumpkin requested a review from a team as a code owner December 31, 2024 15:29
candidates = append(candidates, c)
}

// TODO: Because we disabled the old logic that was fetching modules from Algolia, we'll need to figure out our own solution for modules auto completion
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Potentially, we could use the Registry Search feature for that purpose. However, I'm not sure about the quality and performance for this particular scenario.

Should it also be configurable for private module sources for example?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants