fix(select): [select] emit selected object data on change event #2723
Conversation
WalkthroughThe pull request focuses on enhancing the selection component in Changes
Possibly related PRs
Suggested labels
Suggested reviewers
Poem
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
WalkthroughThis pull request addresses a bug in the select component by modifying the change event to emit the selected object data instead of just the value. This change ensures that the full object data is available after a selection change, enhancing the functionality of the component. Changes
|
![petercat-assistant[bot]](https://avatars.githubusercontent.com/in/875736?s=60&v=4){kind=small}
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 0
🧹 Nitpick comments (1)
packages/renderless/src/select/index.ts (1)
300-306: Ensure consistent handling for empty matches.When
!props.renderType, the code tries to find matching items instate.options, then emitsitems[0]for a single-selection scenario. In the event no match is found,items[0]would beundefined. Verify that this behavior is acceptable in your application logic or add a fallback to prevent emittingundefined.Below is an optional snippet that emits a fallback object if no match is found:
-emit('change', value, props.multiple ? items : items[0]) +const result = props.multiple ? items : items[0] || {} +emit('change', value, result)
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (1)
packages/renderless/src/select/index.ts(2 hunks)
🔇 Additional comments (1)
packages/renderless/src/select/index.ts (1)
267-273: Consider handling potential mismatches or empty arrays.The code only pushes the first matched item and breaks out of the loop, which is aligned with the single-match scenario. However, if
arrhappens to be empty or if no matching item is found,itemsremains empty. You might want to ensure that downstream logic can handle an emptyitemsarray gracefully, especially in single-selection contexts.Would you like me to generate a verification script to check if other parts of the codebase expect a non-empty
itemsarray?
PR
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
Only emit value message on change event.
Issue Number: #2614
What is the new behavior?
The message of selected objects is added after change event.
Does this PR introduce a breaking change?
Other information
Summary by CodeRabbit
Bug Fixes
Improvements