[github-actions] fix NCP border routing setup #2622
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Irving-cl
added
bug
P2
github_actions
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2622 +/- ##
==========================================
- Coverage 55.77% 46.13% -9.65%
==========================================
Files 87 106 +19
Lines 6890 12624 +5734
Branches 0 915 +915
==========================================
+ Hits 3843 5824 +1981
- Misses 3047 6486 +3439
- Partials 0 314 +314 ☔ View full report in Codecov by Sentry. |
jwhui
force-pushed
the
fix_ncp_github_action
branch
from
2dae554
to
2dfabab
Compare
jwhui
approved these changes
Nov 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The PR fixes issue in the github action for testing NCP border routing.
Without
sudothe option cannot be set successfully, and border routing cannot work in the test. Currently the expect script isn't strong enough to detect this problem. I'll enhance the script soon.