Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[continuous-integration] fix and clean up macOS.yml #2619

Merged
merged 1 commit into from
Nov 26, 2024

Conversation

superwhd
Copy link
Contributor

@superwhd superwhd commented Nov 25, 2024

There are macOS workflow failures for new PRs like this:

Error: No such keg: /opt/homebrew/Cellar/pkg-config

I checked macos-14-Readme.md and noticed that some dependencies (like pkg-config) of the macOS workflow are already satisfied by the image so we don't have to reinstall them again.

Also, this PR removes dbus in the macOS workflow because D-BUS is not enabled when building OTBR.

Copy link

codecov bot commented Nov 25, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 45.92%. Comparing base (2b41187) to head (bd62412).
Report is 882 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2619      +/-   ##
==========================================
- Coverage   55.77%   45.92%   -9.86%     
==========================================
  Files          87      106      +19     
  Lines        6890    12624    +5734     
  Branches        0      915     +915     
==========================================
+ Hits         3843     5797    +1954     
- Misses       3047     6511    +3464     
- Partials        0      316     +316     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@superwhd superwhd changed the title [WIP] [continuous-integration] fix and clean up macOS.yml [continuous-integration] fix and clean up macOS.yml Nov 25, 2024
Copy link
Contributor

@Irving-cl Irving-cl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@Irving-cl Irving-cl requested a review from jwhui November 26, 2024 02:31
@jwhui jwhui merged commit faa7966 into openthread:main Nov 26, 2024
32 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants