Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[thread host] Update Leave method #2618

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

Irving-cl
Copy link
Contributor

This PR updates the ThreadHost::Leave method.

This PR adds a parameter aEraseDataset to the method. This PR also implements this method for RcpHost. The implementation is consistent with the android implementation. The PR also adds a unit test for RcpHost::Leave.

Copy link

codecov bot commented Nov 25, 2024

Codecov Report

Attention: Patch coverage is 73.91304% with 24 lines in your changes missing coverage. Please review.

Project coverage is 46.16%. Comparing base (2b41187) to head (f42c814).
Report is 885 commits behind head on main.

Files with missing lines Patch % Lines
tests/gtest/test_rcp_host_api.cpp 81.63% 9 Missing ⚠️
src/ncp/rcp_host.cpp 75.75% 4 Missing and 4 partials ⚠️
src/ncp/ncp_host.cpp 0.00% 6 Missing ⚠️
src/dbus/server/dbus_thread_object_ncp.cpp 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2618      +/-   ##
==========================================
- Coverage   55.77%   46.16%   -9.62%     
==========================================
  Files          87      106      +19     
  Lines        6890    12707    +5817     
  Branches        0      921     +921     
==========================================
+ Hits         3843     5866    +2023     
- Misses       3047     6523    +3476     
- Partials        0      318     +318     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Irving-cl Irving-cl force-pushed the rcp_host_leave_method branch 2 times, most recently from 85ec994 to 323d674 Compare November 25, 2024 11:03
Copy link
Contributor

@sunytt sunytt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

src/ncp/rcp_host.cpp Outdated Show resolved Hide resolved
Copy link
Contributor

@superwhd superwhd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@Irving-cl Irving-cl requested a review from jwhui November 27, 2024 01:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants