-
Notifications
You must be signed in to change notification settings - Fork 235
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[thread host] Update Leave method #2618
base: main
Are you sure you want to change the base?
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2618 +/- ##
==========================================
- Coverage 55.77% 46.16% -9.62%
==========================================
Files 87 106 +19
Lines 6890 12707 +5817
Branches 0 921 +921
==========================================
+ Hits 3843 5866 +2023
- Misses 3047 6523 +3476
- Partials 0 318 +318 ☔ View full report in Codecov by Sentry. |
85ec994
to
323d674
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍
323d674
to
f42c814
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍
This PR updates the
ThreadHost::Leave
method.This PR adds a parameter
aEraseDataset
to the method. This PR also implements this method forRcpHost
. The implementation is consistent with the android implementation. The PR also adds a unit test forRcpHost::Leave
.