Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[host] add active dataset as a network property #2540

Merged
merged 1 commit into from
Oct 17, 2024

Conversation

Irving-cl
Copy link
Contributor

This PR adds active dataset tlvs to NetworkProperties so that for both NCP and RCP active dataset can be accessed directly.

The active dataset is used in many places in the platform code. For example, in android SetThreadEnabled, it will only enable Thread when the active dataset is a valid one.

I verified the NCP case locally by log (dumping the active set and see if it's correctly set). If writing a test for it, we need add one more dbus API, which seems unworthy now.

Copy link

codecov bot commented Oct 14, 2024

Codecov Report

Attention: Patch coverage is 4.16667% with 23 lines in your changes missing coverage. Please review.

Project coverage is 45.43%. Comparing base (2b41187) to head (2adfd2b).
Report is 829 commits behind head on main.

Files with missing lines Patch % Lines
src/ncp/ncp_spinel.cpp 0.00% 12 Missing ⚠️
src/ncp/ncp_host.cpp 14.28% 6 Missing ⚠️
src/ncp/rcp_host.cpp 0.00% 5 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##             main    #2540       +/-   ##
===========================================
- Coverage   55.77%   45.43%   -10.35%     
===========================================
  Files          87      102       +15     
  Lines        6890    11995     +5105     
  Branches        0      877      +877     
===========================================
+ Hits         3843     5450     +1607     
- Misses       3047     6251     +3204     
- Partials        0      294      +294     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Irving-cl Irving-cl force-pushed the network_prop_add_active_dataset branch from 398962d to 2adfd2b Compare October 15, 2024 03:25
Copy link
Contributor

@zhanglongxia zhanglongxia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@abtink abtink left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great. 👍

@jwhui jwhui merged commit db73a9a into openthread:main Oct 17, 2024
32 checks passed
@Irving-cl Irving-cl deleted the network_prop_add_active_dataset branch October 24, 2024 03:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants