-
Notifications
You must be signed in to change notification settings - Fork 235
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[infra if] add platform infra if module #2501
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2501 +/- ##
===========================================
- Coverage 55.77% 45.75% -10.03%
===========================================
Files 87 102 +15
Lines 6890 11971 +5081
Branches 0 876 +876
===========================================
+ Hits 3843 5477 +1634
- Misses 3047 6203 +3156
- Partials 0 291 +291 ☔ View full report in Codecov by Sentry. |
66ad46d
to
78df0b9
Compare
78df0b9
to
bfceb06
Compare
bfceb06
to
104dbe3
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM overall with minor suggestions
84d4b2d
to
b358f5b
Compare
458fa95
to
48cda61
Compare
48cda61
to
4898abe
Compare
4898abe
to
2836f97
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
This PR adds the InfraIf module on the host side.
This is to support border routing for NCP case. See this #2398 (comment) for the whole picture of this series of changes.
In this PR,
InfraIf
module only implementsSetInfraIf
method. This method is intended to be called byNcpHost
during initialization or through ThreadHost API (for example, for the android case, where the infra if is ready later). This method will initialize the infra if and the border routing module on NCP.This PR adds a unit test to verify the
InfraIfDependency
is called correctly.