Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[agent] add application integration for VendorServer instead of NCP #2017

Merged
merged 10 commits into from
Sep 28, 2023

Conversation

morningboata
Copy link
Contributor

This allows VendorServer to visit application and all parts of application through Get API. This addresses the issues like: BorderAgent is not accessible from VendorServer.

… VendorServer to visit all parts of application.
src/agent/application.hpp Outdated Show resolved Hide resolved
src/agent/vendor.hpp Outdated Show resolved Hide resolved
src/agent/vendor.hpp Show resolved Hide resolved
src/agent/application.hpp Show resolved Hide resolved
src/agent/vendor.hpp Outdated Show resolved Hide resolved
Copy link
Contributor

@superwhd superwhd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

Copy link
Member

@wgtdkp wgtdkp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

src/agent/application.hpp Outdated Show resolved Hide resolved
Copy link
Member

@Vyrastas Vyrastas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM for docs/comments

Copy link
Member

@abtink abtink left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. 👍

Couple of small style change suggestions below.

src/agent/vendor.hpp Outdated Show resolved Hide resolved
src/agent/vendor.hpp Outdated Show resolved Hide resolved
@jwhui jwhui changed the title Add application integration for VendorServer instead of NCP [agent] add application integration for VendorServer instead of NCP Sep 28, 2023
@jwhui jwhui merged commit 65a1949 into openthread:main Sep 28, 2023
31 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants