Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[openwrt] enable OTBR_NAT64 and INFRA_IF by default and add UCI config #2011

Merged
merged 1 commit into from
Sep 20, 2023
Merged

[openwrt] enable OTBR_NAT64 and INFRA_IF by default and add UCI config #2011

merged 1 commit into from
Sep 20, 2023

Conversation

ihidchaos
Copy link
Contributor

This commit enables OTBR_NAT64 and INFRA_IF by default, making NAT64 functionality available out-of-the-box on the OpenWrt platform.

At the same time, the RCP serial port configuration is added to the UCI configuration file to make the runtime modifications clearer and to avoid the errors that are easily caused by directly modifying the init.d configuration.

@ihidchaos
Copy link
Contributor Author

The error that occurs should not be caused by this commit.

@ihidchaos
Copy link
Contributor Author

image

The CI/CD passed automatically again without making changes. I guess we need to improve the number of concurrencies in CI/CI to make it a single step test?

In any case, can someone merge it in? @bukepo @xuyirio thanks.

Copy link
Contributor

@xuyirio xuyirio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

One thing to note: querying an AIL NAT64 prefix is currently disabled for OpenWRT (PR).

@ihidchaos
Copy link
Contributor Author

LGTM.

One thing to note: querying an AIL NAT64 prefix is currently disabled for OpenWRT (PR).

According to the description of openwrt/pull/11559, libanl is already included in the musl c library, so we can turn this option on.

Do I need to also submit a modification to CMakeLists.txt#L153 PR?

@xuyirio
Copy link
Contributor

xuyirio commented Sep 20, 2023

LGTM.
One thing to note: querying an AIL NAT64 prefix is currently disabled for OpenWRT (PR).

According to the description of openwrt/pull/11559, libanl is already included in the musl c library, so we can turn this option on.

Do I need to also submit a modification to CMakeLists.txt#L153 PR?

Good to know! Yes, please remove the NOT OT_TARGET_OPENWRT condition and verify the tests are passing.

@jwhui jwhui changed the title [openwrt] Enable OTBR_NAT64 and INFRA_IF by default and add UCI config. [openwrt] enable OTBR_NAT64 and INFRA_IF by default and add UCI config Sep 20, 2023
Copy link
Member

@jwhui jwhui left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! 👍🏼

@jwhui jwhui merged commit 029671f into openthread:main Sep 20, 2023
31 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants