[mdns] update TxtEntry to handle boolean attribute
#1992
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wgtdkp
approved these changes
Sep 5, 2023
abtink
force-pushed
the
mdns/handle-bool-attr-txt-record
branch
from
81c26c6
to
5cf09ee
Compare
This commit updates `TxtEntry`, `EncodeTxtData()`, and `DecodeTxtData()` to support boolean attributes, which are encoded as `key` string without the `=` character. It also ensures that `EncodeTxtData()` will generate valid TXT data (containing a single zero byte) when given an empty `TxtList`. Additionally, this commit updates `AdvertisingProxy::MakeTxtList()` to use `DecodeTxtData()`, and adds a test to validate the encoder and decoder behavior.
abtink
force-pushed
the
mdns/handle-bool-attr-txt-record
branch
from
5cf09ee
to
d419073
Compare
jwhui
approved these changes
Sep 6, 2023
jwhui
changed the title
TxtEntry to handle boolean attribute
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit updates
TxtEntry,EncodeTxtData(), andDecodeTxtData()to support boolean attributes, which are encoded askeystring without the=character. It also ensures thatEncodeTxtData()will generate valid TXT data (containing a single zero byte) when given an emptyTxtList. Additionally, this commit updatesAdvertisingProxy::MakeTxtList()to useDecodeTxtData(), and adds a test to validate the encoder and decoder behavior.