-
Notifications
You must be signed in to change notification settings - Fork 235
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[mdns] update mDNSResponder to 1790.80.10 #1919
[mdns] update mDNSResponder to 1790.80.10 #1919
Conversation
160e814
to
a0d814b
Compare
It seems that some tests fail despite not using mDNSResponder. The reason is that the tests use mDNSResponder (
It could be just timing, or maybe it is really a bug in that new mDNSResponder version. I am currently not setup to run these tests/didn't investigate on how to run them. I probably can look into these issues at one point, but it doesn't seem to be a quick/easy thing from what I can tell. If someone else has a good idea I am happy to hear it. |
7b7211f
to
0280fb1
Compare
With the patches from apple-oss-distributions/mDNSResponder#2 and apple-oss-distributions/mDNSResponder#6 the tests seem to run through nicely (the first time there were some errors, but they were unrelated. With this second run it seems everything is green now. I'll update the branch again to trigger another run, if that returns green again I think it shows some certainty that this the update is solid. |
84b6500
to
d5bd28d
Compare
19ff1b0
to
eace363
Compare
eace363
to
4c442c7
Compare
Any thoughts on this PR? It does address issue we have seen where |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, Thanks!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! 👍🏼
No description provided.