Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[RAO] calculate owner cut first #1169

Merged
merged 1 commit into from
Jan 20, 2025

Conversation

camfairchild
Copy link
Contributor

Description

This PR closes #1167. Previously we were calculating the owner cut after removing the root dividends from the total subent emission.

This change moves the owner cut to before this.

Related Issue(s)

Type of Change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation update
  • Other (please describe):

Checklist

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have run cargo fmt and cargo clippy to ensure my code is formatted and linted correctly
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

@camfairchild camfairchild requested a review from unconst as a code owner January 18, 2025 00:53
@camfairchild camfairchild changed the title calculate owner cut first [RAO] calculate owner cut first Jan 18, 2025
@sam0x17 sam0x17 merged commit e61fd8b into devnet-ready Jan 20, 2025
10 of 11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants