Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: dispose should also delete its all instance cache #110

Merged
merged 6 commits into from
Oct 13, 2023
Merged

fix: dispose should also delete its all instance cache #110

merged 6 commits into from
Oct 13, 2023

Conversation

bytemain
Copy link
Member

close: #109

@codecov
Copy link

codecov bot commented Oct 12, 2023 •
edited
Loading

Codecov Report

All modified lines are covered by tests ✅

Files Coverage Δ
src/decorator.ts 100.00% <100.00%> (ø)
src/helper/event.ts 100.00% <100.00%> (ø)
src/helper/hook-helper.ts 100.00% <100.00%> (ø)
src/injector.ts 100.00% <100.00%> (ø)

📢 Thoughts on this report? Let us know!.

erha19
erha19 previously approved these changes Oct 12, 2023
View reviewed changes
@erha19
Copy link
Member

erha19 commented Oct 12, 2023

@bytemain 感觉这个版本可以在 OpenSumi 里面升级一下，现在测试里面 DI 内存应该是有点高的

@bytemain bytemain changed the title fix: dispose should also delete its all instance cache WIP: fix: dispose should also delete its all instance cache Oct 12, 2023
@bytemain
Copy link
Member Author

还需要处理一下在 useAlias 情况下或者不同 Token 对应同一个 instance 下的问题

@bytemain bytemain changed the title WIP: fix: dispose should also delete its all instance cache fix: dispose should also delete its all instance cache Oct 13, 2023
@bytemain bytemain mentioned this pull request Oct 13, 2023
Closed
@bytemain bytemain merged commit cec693b into main Oct 13, 2023
5 checks passed
@bytemain bytemain deleted the fix/dispose-one-should-delete-cache branch October 13, 2023 03:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@erha19 erha19 erha19 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

使用disposeOne后，实例没有被销毁
2 participants
@bytemain @erha19