Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improvements to danger workflow #5290

Merged
merged 3 commits into from
Oct 27, 2024
Merged

Conversation

tomhughes
Copy link
Member

This gets the danger workflow working by switching to my fixed version (current open upstream as danger/danger#1501) and also tweaks a few other things:

  • Renames the workflow to reflect that this is not just about labelling
  • Drops the run-name so that he runs will be names after the PR instead of all having the same name
  • Adjusts the label names to be consistent with our other labels.

@mmd-osm
Copy link
Contributor

mmd-osm commented Oct 26, 2024

It seems you need to update the commit hash in Gemfile.lock. This works for me:

diff --git a/Gemfile.lock b/Gemfile.lock
index 346af2baa..d1bf08281 100644
--- a/Gemfile.lock
+++ b/Gemfile.lock
@@ -8,7 +8,7 @@ GIT
 
 GIT
   remote: https://github.com/tomhughes/danger.git
-  revision: 5794971ade2fb4239a346a4902700e0c6d4c04c7
+  revision: a265cf74d2f464a25796b48d95697f5eed553454
   ref: pull-request-target
   specs:

@tomhughes
Copy link
Member Author

Ah sorry... I cherry picked and forgot I had updated the danger branch since. Now fixed.

@mmd-osm
Copy link
Contributor

mmd-osm commented Oct 26, 2024

Looks good now. The danger failure is expected, you can't test any changes to Danger with a cross repo PR.

@gravitystorm gravitystorm merged commit 50cfc0a into openstreetmap:master Oct 27, 2024
20 of 21 checks passed
@gravitystorm
Copy link
Collaborator

Thanks for all your work getting to the bottom of this problem!

@tomhughes tomhughes deleted the danger branch October 27, 2024 12:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants