Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Note subscriptions #5283

Closed

Conversation

AntonKhorev
Copy link
Collaborator

@AntonKhorev AntonKhorev commented Oct 24, 2024

Adds a subscription functionality to notes, similar to changesets and diary entry subscriptions.

Without this it's impossible to unsubscribe from notes you may not care about. If you did any mass note manipulation in some area, chances are someone else will start altering these notes later. In this case you'll receive waves of emails and there's no way to stop them.

See also https://osmfoundation.org/wiki/Operations/Minutes/2024-05-02#Discussion_on_spam_reports_via_ISP. "Encourage Microsoft to work on maintaining separate subscriptions for notes, as there was some work already done by them on refactoring the way notes are presented and they are interested in improving the notes." - I'm not sure what work on notes was done by Microsoft at that time.


Needs to be merged in at least two parts because backfilling. Backfilling is done in a migration here which may not be the best idea. We already did data migrations like that but they were simpler.

image

@AntonKhorev AntonKhorev force-pushed the note-subscriptions branch 2 times, most recently from 3b1657c to 1de0127 Compare October 24, 2024 14:35
@AntonKhorev AntonKhorev force-pushed the note-subscriptions branch 4 times, most recently from df53ca0 to f79120a Compare October 25, 2024 15:09
@AntonKhorev AntonKhorev added the notes Related to the notes feature label Oct 25, 2024
@github-actions github-actions bot removed the big-pr label Nov 6, 2024
@matkoniecz
Copy link
Contributor

If you did any mass note manipulation in some area, chances are someone else will start altering these notes later. In this case you'll receive waves of emails and there's no way to stop them.

relatively few mass note manipulation should be done then abandon discussion, though I expect that DWG is often involved in such actions which are entirely valid (undoing mass closing of notes for example)

also, very useful to disengage from very heated discussion where you are unable to participate in an useful way

@AntonKhorev
Copy link
Collaborator Author

DWG is often involved in such actions which are entirely valid (undoing mass closing of notes for example)

Yes. I got a batch of emails about reopened notes today and I got one yesterday.

@AntonKhorev
Copy link
Collaborator Author

Implemented in #5284, #5304, #5310, #5314, #5346.

@AntonKhorev AntonKhorev deleted the note-subscriptions branch November 22, 2024 00:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
notes Related to the notes feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants