-
Notifications
You must be signed in to change notification settings - Fork 921
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Note subscriptions #5283
Note subscriptions #5283
Conversation
3b1657c
to
1de0127
Compare
df53ca0
to
f79120a
Compare
f79120a
to
9bd3f06
Compare
9bd3f06
to
2624faa
Compare
2624faa
to
a366fde
Compare
a366fde
to
d3e2d46
Compare
d3e2d46
to
ffdeb4b
Compare
ffdeb4b
to
98a2874
Compare
relatively few mass note manipulation should be done then abandon discussion, though I expect that DWG is often involved in such actions which are entirely valid (undoing mass closing of notes for example) also, very useful to disengage from very heated discussion where you are unable to participate in an useful way |
Yes. I got a batch of emails about reopened notes today and I got one yesterday. |
Adds a subscription functionality to notes, similar to changesets and diary entry subscriptions.
Without this it's impossible to unsubscribe from notes you may not care about. If you did any mass note manipulation in some area, chances are someone else will start altering these notes later. In this case you'll receive waves of emails and there's no way to stop them.
See also https://osmfoundation.org/wiki/Operations/Minutes/2024-05-02#Discussion_on_spam_reports_via_ISP. "Encourage Microsoft to work on maintaining separate subscriptions for notes, as there was some work already done by them on refactoring the way notes are presented and they are interested in improving the notes." - I'm not sure what work on notes was done by Microsoft at that time.
Needs to be merged in at least two parts because backfilling. Backfilling is done in a migration here which may not be the best idea. We already did data migrations like that but they were simpler.