Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update heading, stripes and tab border colors #4658

Merged

Conversation

AntonKhorev
Copy link
Collaborator

@AntonKhorev AntonKhorev commented Apr 7, 2024

Have to make these changes at the same time to see if they work together:

image

This is how it looks in dark mode:
image

@tomhughes
Copy link
Member

This mostly looks good to me.

I think the only issue is that there's a visible line under the tabs - it's a 1px border on the bottom of the tabs control but it looks odd because it only covers the middle section and not the margins.

It was actually there before, just much harder to see with the old colours....

@AntonKhorev AntonKhorev changed the title Heading stripes tabs colors Update heading, stripes and tab border colors Apr 7, 2024
@tomhughes
Copy link
Member

Thanks - that looks really good now and I actually quite like having that subtle border under the heading.

@AntonKhorev
Copy link
Collaborator Author

Here's the easiest change - add border to every heading section + negative margin to tabs:

image

I can change negative margin to calc(-1 * var(--bs-border-width)) to avoid pixel widths in css.

Other options are:

  • same but with top border for every heading too
  • bottom border only for headings with tabs

@tomhughes tomhughes merged commit 0c4cbda into openstreetmap:master Apr 7, 2024
12 checks passed
@AntonKhorev AntonKhorev deleted the heading-stripes-tabs-colors branch April 8, 2024 10:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants