Update cli endpoint #1073
Merged
Update cli endpoint #1073
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
thibaultleouay
commented
Oct 29, 2024
| @@ -302,5 +307,5 @@ func (h Handler) HTTPCheckerHandler(c *gin.Context) { | |||
|
|
|||
| } | |||
|
|
|||
| c.JSON(http.StatusOK, gin.H{"message": "ok"}) | |||
There was a problem hiding this comment.
@mxkaske we used to return something dummy
I'm returning the result of the ping instead
This is useful to get instant result in the /run endoint
thibaultleouay
commented
Oct 29, 2024
| @@ -196,7 +207,7 @@ func (h Handler) TCPHandler(c *gin.Context) { | |||
| } | |||
| } | |||
|
|
|||
| c.JSON(http.StatusOK, gin.H{"message": "ok"}) | |||
| c.JSON(http.StatusOK, response) | |||
There was a problem hiding this comment.
Same as above
Instead of dummy data return the actual result useful for the run endpoint
thibaultleouay
commented
Oct 29, 2024
There was a problem hiding this comment.
This is mostly copy pasta from trigger/post might going to refactor it after 🤣
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of change
Description
A picture tells a thousand words (if any)
Before this PR
{Please add a screenshot here}
After this PR
{Please add a screenshot here}
Related Issue (optional)