Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[18.0-fr1] Ensure nodeSelector logic is consistent for all operators #505

Merged
merged 3 commits into from
Nov 22, 2024
Merged

[18.0-fr1] Ensure nodeSelector logic is consistent for all operators #505

merged 3 commits into from
Nov 22, 2024
+150 −18

Commits on Nov 22, 2024

  1. Allow empty nodeSelector 

    Switch to a pointer for nodeSelector to allow different logic for empty vs unset
    @olliewalsh
    olliewalsh authored and openshift-cherrypick-robot committed Nov 22, 2024
    Configuration menu
    Copy the full SHA
    5809e7b View commit details
    Browse the repository at this point in the history

  2. Add nodeSelector functional tests

    @olliewalsh
    olliewalsh authored and openshift-cherrypick-robot committed Nov 22, 2024
    Configuration menu
    Copy the full SHA
    142d437 View commit details
    Browse the repository at this point in the history

  3. Pass-through empty nodeSelector to podSpecs 

    There is no need drop empty nodeSelector maps, omitempty already does this
    @olliewalsh
    olliewalsh authored and openshift-cherrypick-robot committed Nov 22, 2024
    Configuration menu
    Copy the full SHA
    038cef2 View commit details
    Browse the repository at this point in the history