-
Notifications
You must be signed in to change notification settings - Fork 59
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Resolve Sync progress going above 100% #3684
base: main
Are you sure you want to change the base?
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #3684 +/- ##
=======================================
Coverage 38.9% 38.9%
- Complexity 1163 1164 +1
=======================================
Files 284 284
Lines 15078 15079 +1
Branches 2671 2672 +1
=======================================
+ Hits 5867 5872 +5
+ Misses 8365 8362 -3
+ Partials 846 845 -1
Flags with carried forward coverage won't be shown. Click here to find out more.
|
is CurrentSyncJobStatus.Running -> { | ||
when { | ||
currentSyncJobStatus is CurrentSyncJobStatus.Running && | ||
appDrawerUIState.percentageProgress!! <= 100 -> { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
if the percent is >100 I think we still want to run the update, we want to change the percent to from >100 to 100
IMPORTANT: Where possible all PRs must be linked to a Github issue
Fixes #3536
Engineer Checklist
strings.xml
file./gradlew spotlessApply
and./gradlew spotlessCheck
to check my code follows the project's style guideCode Reviewer Checklist
strings.xml
file