-
Notifications
You must be signed in to change notification settings - Fork 59
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Composition.entry and Composition.focus #3662
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #3662 +/- ##
=======================================
Coverage 38.9% 38.9%
- Complexity 1159 1164 +5
=======================================
Files 284 284
Lines 15060 15078 +18
Branches 2669 2671 +2
=======================================
+ Hits 5860 5872 +12
- Misses 8356 8361 +5
- Partials 844 845 +1
Flags with carried forward coverage won't be shown. Click here to find out more.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks much better! I made some suggestions to remove duplication, I think the unit you want to share is the reference not the section, please take a look, thank you
...ngine/src/main/java/org/smartregister/fhircore/engine/configuration/ConfigurationRegistry.kt
Outdated
Show resolved
Hide resolved
...ngine/src/main/java/org/smartregister/fhircore/engine/configuration/ConfigurationRegistry.kt
Outdated
Show resolved
Hide resolved
...ngine/src/main/java/org/smartregister/fhircore/engine/configuration/ConfigurationRegistry.kt
Outdated
Show resolved
Hide resolved
...ngine/src/main/java/org/smartregister/fhircore/engine/configuration/ConfigurationRegistry.kt
Outdated
Show resolved
Hide resolved
...ngine/src/main/java/org/smartregister/fhircore/engine/configuration/ConfigurationRegistry.kt
Outdated
Show resolved
Hide resolved
...ngine/src/main/java/org/smartregister/fhircore/engine/configuration/ConfigurationRegistry.kt
Outdated
Show resolved
Hide resolved
...ngine/src/main/java/org/smartregister/fhircore/engine/configuration/ConfigurationRegistry.kt
Outdated
Show resolved
Hide resolved
…e into add-entry-to-composition
…e into add-entry-to-composition
…e into add-entry-to-composition
IMPORTANT: Where possible all PRs must be linked to a Github issue
Fixes #3617
Engineer Checklist
strings.xml
file./gradlew spotlessApply
and./gradlew spotlessCheck
to check my code follows the project's style guideCode Reviewer Checklist
strings.xml
file