Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add packet to boskos reaper #7926

Merged
merged 1 commit into from
Mar 26, 2020

Conversation

honza
Copy link
Member

@honza honza commented Mar 25, 2020

No description provided.

@openshift-ci-robot openshift-ci-robot added lgtm Indicates that a PR is ready to be merged. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Mar 25, 2020
@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@alvaroaleman
Copy link
Contributor

/lgtm cancel
the config for the app.ci cluster needs updating, please do not use the maketarget but add the config

@openshift-ci-robot openshift-ci-robot removed the lgtm Indicates that a PR is ready to be merged. label Mar 25, 2020
@honza
Copy link
Member Author

honza commented Mar 26, 2020

the config for the app.ci cluster needs updating, please do not use the maketarget but add the config

Would you mind fleshing this out a bit? I'm not super familiar with the all of the various pieces involved...

@alvaroaleman
Copy link
Contributor

Would you mind fleshing this out a bit? I'm not super familiar with the all of the various pieces involved...

The same change you made in core-services/prow/03_deployment/boskos_reaper.yaml also need to be made in clusters/app.ci/prow/03_deployment/boskos_reaper.yaml. You can use verify-app-ci to verify.

The background on this is that we are currently working on migrating Prow itself onto a dedicated cluster, which means that we need to version an almost-but-not-quite identical copy of the config in the meantime.

@honza
Copy link
Member Author

honza commented Mar 26, 2020

Thanks! I just updated the other file.

@alvaroaleman
Copy link
Contributor

@honza and because that changes the hash of the file, you need to run make update-app-ci and add the change to the PR, sorry for the hassle.

@openshift-ci-robot openshift-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Mar 26, 2020
@openshift-ci-robot openshift-ci-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Mar 26, 2020
@honza
Copy link
Member Author

honza commented Mar 26, 2020

No worries at all, thanks for your help. Updated, and rebased on top of master.

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Mar 26, 2020
@openshift-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: alvaroaleman, honza, stevekuznetsov

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-robot openshift-merge-robot merged commit 04ba7b5 into openshift:master Mar 26, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants