enable passing user ca bundle data as file to rosa #2713
Conversation
openshift-ci
bot
added
the
approved
pkg/common/config/config.go
Outdated
| tmpDir, _ := os.MkdirTemp("", "") | ||
| tmpFile, _ := os.CreateTemp(tmpDir, "*") |
There was a problem hiding this comment.
| tmpDir, _ := os.MkdirTemp("", "") | |
| tmpFile, _ := os.CreateTemp(tmpDir, "*") | |
| tmpFile, _ := os.CreateTemp("", "osde2e-userca-bundle-data-") |
I think just writing to base tmp is fine but I'd give it a prefixed name
There was a problem hiding this comment.
prefixed with secret name (eg proxy.user_ca_bundle_data-<>)
There was a problem hiding this comment.
If you are going to leave the tmpdir, I'd prefix that instead of the file so we know what/where those directories come from
| @@ -188,15 +188,6 @@ var _ = Describe("SDN migration", ginkgo.Ordered, func() { | |||
| }) | |||
| }) | |||
|
|
|||
| // getEnvVar returns the env variable value and if unset returns default provided | |||
| func getEnvVar(key, value string) string { | |||
There was a problem hiding this comment.
Hmm I don't think we should delete any of Courtney's stuff.
There was a problem hiding this comment.
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: MrSantamaria, ritmun The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/hold |
openshift-ci
bot
added
the
do-not-merge/hold
|
@ritmun: The following tests failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
|
Issues go stale after 90d of inactivity. Mark the issue as fresh by commenting If this issue is safe to close now please do so with /lifecycle stale |
openshift-ci
bot
added
the
lifecycle/stale
openshift-merge-robot
added
the
needs-rebase
|
PR needs rebase. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
This change allows storing ca bundle in temp file and passing that path to rosa
[ Gap analysis 4.17 ]