Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

OSDOCS-7061: Documented the AWS Wavelength zone feature #69537

Merged
merged 1 commit into from
Feb 15, 2024
Merged

OSDOCS-7061: Documented the AWS Wavelength zone feature #69537

merged 1 commit into from
Feb 15, 2024

Conversation

dfitzmau
Copy link
Contributor

@dfitzmau dfitzmau commented Dec 18, 2023 •
edited
Loading

Version(s):
4.15

Issue:
OSDOCS-7061

Link to docs preview:

SME review:

  • [SME ack]

QE review:

Screenshot from 2024-02-09 11-22-27

Additional information:
https://github.com/openshift/openshift-docs/pull/69128/files

@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Dec 18, 2023
@openshift-ci-robot
Copy link

openshift-ci-robot commented Dec 18, 2023 •
edited by openshift-ci bot
Loading

@dfitzmau: This pull request references OSDOCS-7061 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the epic to target the "4.16.0" version, but no target version was set.

In response to this:

OSDOCS-7061

Version(s):
4.15

Issue:

Link to docs preview:

QE review:

  • QE has approved this change.

Additional information:
https://github.com/openshift/openshift-docs/pull/69128/files

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci openshift-ci bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Dec 18, 2023
@ocpdocs-previewbot
Copy link

ocpdocs-previewbot commented Dec 18, 2023 •
edited
Loading

🤖 Thu Feb 15 19:48:34 - Prow CI generated the docs preview: https://69537--ocpdocs-pr.netlify.app

@openshift-ci openshift-ci bot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Dec 19, 2023
@dfitzmau dfitzmau force-pushed the OSDOCS-7061 branch 2 times, most recently from 4477852 to e8c0137 Compare December 19, 2023 17:22
@openshift-ci openshift-ci bot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Dec 19, 2023
@openshift-ci openshift-ci bot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Dec 20, 2023
@dfitzmau dfitzmau force-pushed the OSDOCS-7061 branch 2 times, most recently from c2c00bf to 3c12fb1 Compare December 20, 2023 12:12
@openshift-ci openshift-ci bot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Dec 20, 2023
@dfitzmau dfitzmau force-pushed the OSDOCS-7061 branch 3 times, most recently from 0863650 to b8266aa Compare December 20, 2023 13:01
@openshift-ci openshift-ci bot added size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Dec 20, 2023
@dfitzmau dfitzmau force-pushed the OSDOCS-7061 branch 7 times, most recently from ad3a5d6 to 52bcc85 Compare December 20, 2023 16:02
@dfitzmau dfitzmau force-pushed the OSDOCS-7061 branch 2 times, most recently from 9084823 to 41f7cef Compare February 15, 2024 16:19
mtulio
mtulio approved these changes Feb 15, 2024
View reviewed changes
Copy link
Contributor

@mtulio mtulio left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job, @dfitzmau ! Thanks for the partnership in this journey! 🚀
/lgtm

@dfitzmau
Copy link
Contributor Author

/label merge-review-needed

@openshift-ci-robot
Copy link

@dfitzmau: This pull request references OSDOCS-7061 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the epic to target the "4.16.0" version, but no target version was set.

In response to this:

Version(s):
4.15

Issue:
OSDOCS-7061

Link to docs preview:

SME review:

  • [x]

QE review:

Screenshot from 2024-02-09 11-22-27

Additional information:
https://github.com/openshift/openshift-docs/pull/69128/files

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci-robot
Copy link

openshift-ci-robot commented Feb 15, 2024 •
edited by openshift-ci bot
Loading

@dfitzmau: This pull request references OSDOCS-7061 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the epic to target the "4.16.0" version, but no target version was set.

In response to this:

Version(s):
4.15

Issue:
OSDOCS-7061

Link to docs preview:

SME review:

  • [SME ack]

QE review:

Screenshot from 2024-02-09 11-22-27

Additional information:
https://github.com/openshift/openshift-docs/pull/69128/files

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@dfitzmau
Copy link
Contributor Author

/label merge-review-needed

@openshift-ci openshift-ci bot added the merge-review-needed Signifies that the merge review team needs to review this PR label Feb 15, 2024
@mjpytlak mjpytlak added merge-review-in-progress Signifies that the merge review team is reviewing this PR and removed merge-review-needed Signifies that the merge review team needs to review this PR labels Feb 15, 2024
@dfitzmau dfitzmau force-pushed the OSDOCS-7061 branch 2 times, most recently from acbfdb3 to 9203fb6 Compare February 15, 2024 18:50
mjpytlak
mjpytlak reviewed Feb 15, 2024
View reviewed changes
Copy link
Contributor

@mjpytlak mjpytlak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@dfitzmau Both Ben and I took another pass at this. I did find one condition that needs your attention ahead of a merge. I did notice that you have several other questions out to Marco, so I will ask that you reach out in this PR after you have addressed the one item I found, anything Ben has found, and when you are satisfied that you do not need further input from Marco. Thank you. Almost there...

modules/installation-creating-aws-vpc-localzone.adoc Outdated
After the `StackStatus` displays `CREATE_COMPLETE`, the output displays values
for the following parameters. You must provide these parameter values to
the other CloudFormation templates that you run to create your cluster:
After the `StackStatus` displays `CREATE_COMPLETE`, the output displays values for the following parameters. You must provide these parameter values to the other CloudFormation templates that you run to create your cluster:
Copy link
Contributor

@mjpytlak mjpytlak Feb 15, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@dfitzmau I do not believe @ShaunaDiaz is suggesting that you remove the statement. Rather, she is suggesting that you add "You must provide these parameter values to the other CloudFormation templates that you run to create your cluster." after line 102. I do not think this is must have for GA.

modules/installation-user-infra-generate.adoc
ifeval::["{context}" == "installing-aws-wavelength-zone"]
:cp-first: Amazon Web Services
:cp: AWS
:aws:
Copy link
Contributor

@mjpytlak mjpytlak Feb 15, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@bscott-rh Gut check on this. This appears to be empty in every ifeval directive. Can you think of a reason this would be here. Appears to be a copy/paste from previous ifevals

modules/installation-generate-aws-user-infra-install-config.adoc Show resolved Hide resolved
@dfitzmau
Copy link
Contributor Author

stalling-aws-wavelength-zon

Stephanie, myself, and Marco agreed to leave minor items as a post-GA items. I can address your feedback.

@dfitzmau dfitzmau force-pushed the OSDOCS-7061 branch 3 times, most recently from 7811fb1 to 38f6d3e Compare February 15, 2024 19:42
@openshift-ci OpenShift CI
Copy link

openshift-ci bot commented Feb 15, 2024

@dfitzmau: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@bscott-rh
Copy link
Contributor

Rest of the PR LGTM on my second pass.

@mjpytlak
Copy link
Contributor

@dfitzmau reached out to me in Slack to request the merge.

@mjpytlak mjpytlak merged commit af83e5f into openshift:main Feb 15, 2024
2 checks passed
@mjpytlak
Copy link
Contributor

/cherrypick enterprise-4.15

@openshift-cherrypick-robot
Copy link

@mjpytlak: new pull request created: #71713

In response to this:

/cherrypick enterprise-4.15

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-cherrypick-robot openshift-cherrypick-robot mentioned this pull request Feb 15, 2024
Merged
@yunjiang29
Copy link
Contributor

/lgtm

@dfitzmau dfitzmau mentioned this pull request Mar 15, 2024
Closed
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ShaunaDiaz ShaunaDiaz ShaunaDiaz left review comments

@bscott-rh bscott-rh bscott-rh left review comments

@Phaow Phaow Phaow left review comments

@mjpytlak mjpytlak mjpytlak left review comments

@yunjiang29 yunjiang29 yunjiang29 left review comments

@jeana-redhat jeana-redhat jeana-redhat left review comments

@makentenza makentenza makentenza left review comments

@mtulio mtulio mtulio approved these changes

Assignees
No one assigned
Labels
branch/enterprise-4.15 jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. merge-review-in-progress Signifies that the merge review team is reviewing this PR peer-review-done Signifies that the peer review team has reviewed this PR size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Milestone
OCP 4.15 GA
Development

Successfully merging this pull request may close these issues.