Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

LOG-6321: Disable log level discovery for OpenShift tenancy modes #388

Merged
merged 1 commit into from
Oct 28, 2024
Merged

LOG-6321: Disable log level discovery for OpenShift tenancy modes #388

merged 1 commit into from
Oct 28, 2024

Conversation

xperimental
Copy link

What this PR does / why we need it:

Backport of grafana#14613 to release-5.9

@xperimental xperimental requested a review from periklis as a code owner October 28, 2024 13:28
@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Oct 28, 2024
@openshift-ci-robot
Copy link

openshift-ci-robot commented Oct 28, 2024 •
edited by openshift-ci bot
Loading

@xperimental: This pull request references LOG-6321 which is a valid jira issue.

In response to this:

What this PR does / why we need it:

Backport of grafana#14613 to release-5.9

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 28, 2024
@xperimental
Copy link
Author

/hold changelog missing

@openshift-ci openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Oct 28, 2024
@xperimental xperimental force-pushed the disable-log-level-discovery-5.9 branch from 6690682 to d84bcc3 Compare October 28, 2024 13:56
periklis
periklis approved these changes Oct 28, 2024
View reviewed changes
Copy link

@periklis periklis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Oct 28, 2024
@openshift-ci OpenShift CI
Copy link

openshift-ci bot commented Oct 28, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: periklis, xperimental

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [periklis,xperimental]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@xperimental
Copy link
Author

/unhold

@openshift-ci openshift-ci bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Oct 28, 2024
@xperimental
Copy link
Author

/retest-required

@openshift-ci OpenShift CI
Copy link

openshift-ci bot commented Oct 28, 2024

@xperimental: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@openshift-merge-bot openshift-merge-bot bot merged commit 678afc0 into openshift:release-5.9 Oct 28, 2024
7 checks passed
@xperimental xperimental deleted the disable-log-level-discovery-5.9 branch October 29, 2024 16:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@periklis periklis periklis approved these changes

@JoaoBraveCoding JoaoBraveCoding Awaiting requested review from JoaoBraveCoding

Assignees

@periklis periklis

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@xperimental @openshift-ci-robot @periklis