Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

OLS-1093: Enable hermetic build for the rag-content component #124

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

OLS-1093: Enable hermetic build for the rag-content component #124

wants to merge 2 commits into from

Conversation

syedriko
Copy link
Contributor

@syedriko syedriko commented Oct 7, 2024 •
edited
Loading

Enable hermetic build for the rag-content component

JIRA: https://issues.redhat.com/browse/OLS-1093

@openshift-ci openshift-ci bot requested review from asamal4 and bparees October 7, 2024 20:38
@syedriko syedriko force-pushed the syedriko-hermetic-build branch 5 times, most recently from 9174d39 to dac7551 Compare October 8, 2024 18:12
@openshift-merge-robot openshift-merge-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Oct 14, 2024
@openshift-merge-robot openshift-merge-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Oct 19, 2024
@syedriko syedriko force-pushed the syedriko-hermetic-build branch 4 times, most recently from 145dee0 to 2cca8ac Compare October 20, 2024 03:05
@openshift-merge-robot openshift-merge-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Oct 22, 2024
@openshift-merge-robot openshift-merge-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Oct 22, 2024
@syedriko
Copy link
Contributor Author

/retest

1 similar comment
@syedriko
Copy link
Contributor Author

/retest

@syedriko syedriko force-pushed the syedriko-hermetic-build branch 6 times, most recently from 0d7fe24 to 84e0442 Compare November 19, 2024 03:45
@syedriko
Copy link
Contributor Author

/retest

@syedriko syedriko force-pushed the syedriko-hermetic-build branch 2 times, most recently from fddb26e to 29e09d4 Compare November 19, 2024 19:19
@syedriko
Copy link
Contributor Author

/retest

1 similar comment
@syedriko
Copy link
Contributor Author

/retest

@syedriko syedriko changed the title Enable hermetic build in Konflux OLS-1093: Enable hermetic build in Konflux Nov 20, 2024
@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Nov 20, 2024
@openshift-ci-robot
Copy link

openshift-ci-robot commented Nov 20, 2024 •
edited by openshift-ci bot
Loading

@syedriko: This pull request references OLS-1093 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.18.0" version, but no target version was set.

In response to this:

Enable hermetic build in Konflux

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci-robot
Copy link

openshift-ci-robot commented Nov 20, 2024 •
edited by openshift-ci bot
Loading

@syedriko: This pull request references OLS-1093 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.18.0" version, but no target version was set.

In response to this:

Enable hermetic build in Konflux

JIRA: https://issues.redhat.com/browse/OLS-1093

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@syedriko syedriko changed the title OLS-1093: Enable hermetic build in Konflux OLS-1093: Enable hermetic build for the rag-content component Nov 20, 2024
@openshift-ci-robot
Copy link

openshift-ci-robot commented Nov 20, 2024 •
edited by openshift-ci bot
Loading

@syedriko: This pull request references OLS-1093 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.18.0" version, but no target version was set.

In response to this:

Enable hermetic build for the rag-content component

JIRA: https://issues.redhat.com/browse/OLS-1093

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@syedriko syedriko force-pushed the syedriko-hermetic-build branch 8 times, most recently from c6eba0c to 4582522 Compare November 21, 2024 19:26
@syedriko
Copy link
Contributor Author

/approve
/override "Red Hat Konflux / ols-enterprise-contract / lightspeed-rag-content"

@openshift-ci OpenShift CI
Copy link

openshift-ci bot commented Nov 21, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: syedriko

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 21, 2024
@openshift-ci OpenShift CI
Copy link

openshift-ci bot commented Nov 21, 2024

@syedriko: Overrode contexts on behalf of syedriko: Red Hat Konflux / ols-enterprise-contract / lightspeed-rag-content

In response to this:

/approve
/override "Red Hat Konflux / ols-enterprise-contract / lightspeed-rag-content"

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@syedriko
Copy link
Contributor Author

@asamal4 could you review and lgtm this, please?

In order for the build to be hermetic, this prefetches Python packages, a few rpms as well as the embedding model's blob.

https://konflux-ci.dev/docs/how-tos/configuring/prefetching-dependencies/#enabling-prefetch-builds-for-rpm and
https://github.com/containerbuildsystem/cachi2/blob/main/docs/generic.md are the background on the rpm and generic fetchers in Cachi2.

@openshift-ci OpenShift CI
Copy link

openshift-ci bot commented Nov 23, 2024

@syedriko: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@asamal4 asamal4 Awaiting requested review from asamal4

@bparees bparees Awaiting requested review from bparees

Assignees
No one assigned
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@syedriko @openshift-ci-robot @openshift-merge-robot