LOG-5637: e2e Cluster Logging OTEL support #1684
Conversation
openshift-ci-robot
added
the
jira/valid-reference
|
@jcantrill: This pull request references LOG-5637 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the epic to target the "4.18.0" version, but no target version was set. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
/hold |
openshift-ci
bot
added
the
do-not-merge/hold
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: alanconway The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
bot
added
the
approved
|
/hold cancel |
openshift-ci
bot
removed
the
do-not-merge/hold
|
|
||
| #### Log Visualization | ||
|
|
||
| The **Logging UIPlugin** will be modified to replace its UI widgets to rely upon OTEL attributes in lieu of ViaQ. These changes will be |
There was a problem hiding this comment.
These changes will be released to production one release after the other components achieve GA. can you explain this sentence? I think Logging visualization must be ready when the other components achieve GA.
There was a problem hiding this comment.
This enhancement provides a path for users to continue to use visualization when there is a mismatch between visualization and what attributes are forwarded by the collector. The intent, as suggested by PM, is to only forward OTEL attributes when GA, allow old data to essentially expire or role off, and then introduce the visualization that only relies upon OTEL attributes.
|
|
||
| ### API Extensions | ||
|
|
||
| During the time this feature is considered Tech Preview, instances of **ClusterLogForwarder** will be [annotated](./forwarder-to-otlp.md) to enable |
There was a problem hiding this comment.
Seems like this reference is broken
There was a problem hiding this comment.
I am unable to replicate. Viewing the file I am able to navigate to the link.
| kind: ClusterLogForwarder | ||
| spec: |
There was a problem hiding this comment.
Should we add the required tech preview annotation here? Unless I missed it in this document we don't specify what the annotation looks like
|
@jcantrill: all tests passed! Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
|
/lgtm |
|
/unhold |
This PR:
ref: https://issues.redhat.com/browse/LOG-5637
cc @periklis @alanconway @mwringe @xperimental @cahartma @Clee2691 @jgbernalp