NO-JIRA: use scrape class to avoid TLS config repetitions

[simonpasquier]

• I added CHANGELOG entry for this change.
• No user facing changes, so no entry in CHANGELOG was needed.

[openshift-ci-robot]

@simonpasquier: This pull request explicitly references no jira issue.

In response to this:

• I added CHANGELOG entry for this change.
• No user facing changes, so no entry in CHANGELOG was needed.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[slashpai]

/retest-required

[simonpasquier]

@slashpai the CI failure looks legit

[simonpasquier]

/retest-required

[openshift-ci]

@simonpasquier: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

[simonpasquier]

@jan--f this is a small improvement to reduce coupling between the service monitors and the platform Prometheus: instead of hardcoding file paths in all service monitors, we can refer to the scrape class name defined in the Prometheus object. Eventually we can modify other core operators to do the same.

[jan--f]

Sorry, lost track of this. Feel free to mark this critical if this should make it into 4.18. I assume though it can wait?
/lgtm

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jan--f, simonpasquier

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [jan--f,simonpasquier]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[simonpasquier]

I assume though it can wait?

Totally.

cc @frzifus, if/when this merges, you won't be able to reuse the service monitors without supporting scrape classes in the opentelemetry operator (or a similar mechanism).