Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

OCPBUGS-36357: Replace watches for CO, Proxy and Machine with actual Watches #452

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

OCPBUGS-36357: Replace watches for CO, Proxy and Machine with actual Watches #452

wants to merge 1 commit into from

Conversation

elfosardo
Copy link
Contributor

Readding the watchOCPConfigPullSecret function to allow triggering reconciliation of the provisioning CR.

@elfosardo
Replace watches for CO, Proxy and Machine with actual Watches
dbd1fa2 
Readding the watchOCPConfigPullSecret function to allow triggering
reconciliation of the provisioning CR.
@openshift-ci-robot openshift-ci-robot added jira/severity-low Referenced Jira bug's severity is low for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. labels Oct 18, 2024
@openshift-ci-robot
Copy link
Contributor

@elfosardo: This pull request references Jira Issue OCPBUGS-36357, which is valid. The bug has been moved to the POST state.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (4.18.0) matches configured target version for branch (4.18.0)
  • bug is in the state ASSIGNED, which is one of the valid states (NEW, ASSIGNED, POST)

Requesting review from QA contact:
/cc @jadhaj

The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

Readding the watchOCPConfigPullSecret function to allow triggering reconciliation of the provisioning CR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Oct 18, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: elfosardo

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 18, 2024
@elfosardo
Copy link
Contributor Author

/retest

2 similar comments
@elfosardo
Copy link
Contributor Author

/retest

@elfosardo
Copy link
Contributor Author

/retest

@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Oct 22, 2024

@elfosardo: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-metal-ipi-upgrade-ovn-ipv6 dbd1fa2 link false /test e2e-metal-ipi-upgrade-ovn-ipv6

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

dtantsur
dtantsur reviewed Nov 20, 2024
View reviewed changes
controllers/provisioning_controller.go

// Watch Secret openshift-config/pull-secret. If this secret changes, we must requeue the provisioning Singleton,
// if it exists.
watchOCPConfigPullSecret := func(ctx context.Context, object client.Object) []reconcile.Request {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: this variable is confusingly named: it's not used just for the pull secret

@dtantsur
Copy link
Member

Looks good to me, but I'd like like @zaneb to have a look.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dtantsur dtantsur dtantsur left review comments

@jadhaj jadhaj Awaiting requested review from jadhaj

@andfasano andfasano Awaiting requested review from andfasano

@zaneb zaneb Awaiting requested review from zaneb

Assignees
No one assigned
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/severity-low Referenced Jira bug's severity is low for the branch this PR is targeting. jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@elfosardo @openshift-ci-robot @dtantsur