Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MGMT-18852: Static IP validation #2593

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

eifrach
Copy link
Contributor

@eifrach eifrach commented Dec 11, 2024

Adding validation for static IP's.
This will check the current IP vs the static config and return validation error if one or more are not matching

@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Dec 11, 2024
@openshift-ci-robot
Copy link

openshift-ci-robot commented Dec 11, 2024

@eifrach: This pull request references MGMT-18852 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the bug to target the "4.19.0" version, but no target version was set.

In response to this:

Adding validation for static IP's.
This will check the current IP vs the static config and return validation error if one or more are not matching

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci bot requested review from avishayt and tsorya December 11, 2024 09:36
@openshift-ci openshift-ci bot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Dec 11, 2024
Copy link

openshift-ci bot commented Dec 11, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: eifrach

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 11, 2024
@eifrach
Copy link
Contributor Author

eifrach commented Dec 11, 2024

/test ?

Copy link

openshift-ci bot commented Dec 11, 2024

@eifrach: The following commands are available to trigger required jobs:

/test e2e-metal-assisted-4-18
/test e2e-metal-assisted-bond-4-14
/test e2e-metal-assisted-kube-api-net-suite-4-18
/test e2e-metal-assisted-static-ip-suite-4-14
/test e2e-metal-sno-live-iso
/test e2e-metal-sno-with-worker-live-iso
/test images
/test lint

The following commands are available to trigger optional jobs:

/test e2e-metal-assisted-4-12
/test e2e-metal-assisted-4-13
/test e2e-metal-assisted-4-14
/test e2e-metal-assisted-4-15
/test e2e-metal-assisted-4-16
/test e2e-metal-assisted-bond-4-18
/test e2e-metal-assisted-cnv-4-17
/test e2e-metal-assisted-day2-4-18
/test e2e-metal-assisted-day2-arm-workers-4-18
/test e2e-metal-assisted-day2-sno-4-18
/test e2e-metal-assisted-external-4-16
/test e2e-metal-assisted-external-4-18
/test e2e-metal-assisted-ha-kube-api-4-18
/test e2e-metal-assisted-ha-kube-api-ipv4-4-18
/test e2e-metal-assisted-ha-kube-api-ipv6-4-18
/test e2e-metal-assisted-ipv4v6-4-18
/test e2e-metal-assisted-ipv6-4-18
/test e2e-metal-assisted-ipxe-4-18
/test e2e-metal-assisted-kube-api-late-binding-sno-4-18
/test e2e-metal-assisted-kube-api-late-unbinding-sno-4-18
/test e2e-metal-assisted-kube-api-reclaim-4-18
/test e2e-metal-assisted-kube-api-reclaim-sno-4-18
/test e2e-metal-assisted-lvm-4-18
/test e2e-metal-assisted-mce-4-18
/test e2e-metal-assisted-mce-sno-4-18
/test e2e-metal-assisted-metallb-4-18
/test e2e-metal-assisted-mtv-4-17
/test e2e-metal-assisted-none-4-18
/test e2e-metal-assisted-odf-4-17
/test e2e-metal-assisted-onprem-4-18
/test e2e-metal-assisted-osc-4-17
/test e2e-metal-assisted-osc-sno-4-17
/test e2e-metal-assisted-sno-4-18
/test e2e-metal-assisted-static-ip-suite-4-18
/test e2e-metal-assisted-tang-4-18
/test e2e-metal-assisted-tpmv2-4-18
/test e2e-metal-assisted-upgrade-agent-4-18
/test e2e-metal-ctlplane-scaleup-4-17
/test e2e-nutanix-assisted-4-14
/test e2e-nutanix-assisted-4-15
/test e2e-nutanix-assisted-4-16
/test e2e-nutanix-assisted-4-18
/test e2e-oci-assisted-4-16
/test e2e-oci-assisted-4-18
/test e2e-oci-assisted-iscsi-4-18
/test e2e-vsphere-assisted-4-14
/test e2e-vsphere-assisted-4-15
/test e2e-vsphere-assisted-4-16
/test e2e-vsphere-assisted-4-18
/test e2e-vsphere-assisted-kube-api-4-18
/test e2e-vsphere-assisted-umn-4-18
/test opct-oci-assisted-4-18

Use /test all to run the following jobs that were automatically triggered:

pull-ci-openshift-assisted-test-infra-master-e2e-metal-assisted-4-18
pull-ci-openshift-assisted-test-infra-master-e2e-metal-assisted-kube-api-late-binding-sno-4-18
pull-ci-openshift-assisted-test-infra-master-e2e-metal-assisted-kube-api-net-suite-4-18
pull-ci-openshift-assisted-test-infra-master-e2e-metal-sno-live-iso
pull-ci-openshift-assisted-test-infra-master-images
pull-ci-openshift-assisted-test-infra-master-lint

In response to this:

/test ?

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@eifrach
Copy link
Contributor Author

eifrach commented Dec 11, 2024

/test /test e2e-metal-assisted-static-ip-suite-4-18

@eifrach eifrach marked this pull request as draft December 11, 2024 10:11
@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Dec 11, 2024
@eifrach
Copy link
Contributor Author

eifrach commented Dec 11, 2024

/test lint

@eifrach
Copy link
Contributor Author

eifrach commented Dec 11, 2024

/test lint

Copy link

openshift-ci bot commented Dec 11, 2024

@eifrach: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/lint a81327d link true /test lint

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants