fix: change receiver to pointer for listener and priorityQueue

.golangci.yml

@@ -30,6 +30,8 @@ linters-settings:
     extra-rules: true
 linters:
   enable:
+    - recvcheck
+    - iface
     - asasalint
     - asciicheck
     - bidichk

pkg/adapter/adapter.go

@@ -108,7 +108,7 @@ func (l *listener) Start(ctx context.Context) error {
 	return nil
 }
 
-func (l listener) handleEvent(ctx context.Context) http.HandlerFunc {
+func (l *listener) handleEvent(ctx context.Context) http.HandlerFunc {
 	return func(response http.ResponseWriter, request *http.Request) {
 		if request.Method != http.MethodPost {
 			l.writeResponse(response, http.StatusOK, "ok")
@@ -206,7 +206,7 @@ func (l listener) handleEvent(ctx context.Context) http.HandlerFunc {
 	}
 }
 
-func (l listener) processRes(processEvent bool, provider provider.Interface, logger *zap.SugaredLogger, skipReason string, err error) (provider.Interface, *zap.SugaredLogger, error) {
+func (l *listener) processRes(processEvent bool, provider provider.Interface, logger *zap.SugaredLogger, skipReason string, err error) (provider.Interface, *zap.SugaredLogger, error) {
 	if processEvent {
 		provider.SetLogger(logger)
 		return provider, logger, nil
@@ -223,7 +223,7 @@ func (l listener) processRes(processEvent bool, provider provider.Interface, log
 	return nil, logger, fmt.Errorf("skipping non supported event")
 }
 
-func (l listener) detectProvider(req *http.Request, reqBody string) (provider.Interface, *zap.SugaredLogger, error) {
+func (l *listener) detectProvider(req *http.Request, reqBody string) (provider.Interface, *zap.SugaredLogger, error) {
 	log := *l.logger
 
 	// payload validation
@@ -267,7 +267,7 @@ func (l listener) detectProvider(req *http.Request, reqBody string) (provider.In
 	return l.processRes(false, nil, logger, "", fmt.Errorf("no supported Git provider has been detected"))
 }
 
-func (l listener) writeResponse(response http.ResponseWriter, statusCode int, message string) {
+func (l *listener) writeResponse(response http.ResponseWriter, statusCode int, message string) {
 	response.WriteHeader(statusCode)
 	response.Header().Set("Content-Type", "application/json")
 	body := Response{

pkg/adapter/tls.go

@@ -13,7 +13,7 @@ const tlsMountPath = "/etc/pipelines-as-code/tls"
 
 // isTLSEnabled validates if tls secret exist and if the required fields are defined
 // this is used to enable tls on the listener.
-func (l listener) isTLSEnabled() (bool, string, string) {
+func (l *listener) isTLSEnabled() (bool, string, string) {
 	tlsSecret := os.Getenv("TLS_SECRET_NAME")
 	tlsKey := os.Getenv("TLS_KEY")
 	tlsCert := os.Getenv("TLS_CERT")

pkg/sync/priority_queue.go

@@ -49,13 +49,13 @@ func (pq *priorityQueue) peek() *item {
 	return pq.items[0]
 }
 
-func (pq priorityQueue) Len() int { return len(pq.items) }
+func (pq *priorityQueue) Len() int { return len(pq.items) }
 
-func (pq priorityQueue) Less(i, j int) bool {
+func (pq *priorityQueue) Less(i, j int) bool {
 	return pq.items[i].priority < pq.items[j].priority
 }
 
-func (pq priorityQueue) Swap(i, j int) {
+func (pq *priorityQueue) Swap(i, j int) {
 	pq.items[i], pq.items[j] = pq.items[j], pq.items[i]
 	pq.items[i].index = i
 	pq.items[j].index = j