OCM-9884 | feat: add AWSVolume to AWSNodePool to support custom disk sizes #967
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
marcolan018
reviewed
Jul 29, 2024
willkutler
force-pushed
the
feat/OCM-9884
branch
from
3cd3fec to
7b85c45
Compare
…sizes Signed-off-by: wkutler <[email protected]>
willkutler
force-pushed
the
feat/OCM-9884
branch
from
7b85c45 to
122857a
Compare
|
lgtm |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://issues.redhat.com/browse/OCM-9884
As part of the custom worker disk sizes epic https://issues.redhat.com/browse/XCMSTRAT-285 we want to store the desired size for the custom disk size in an AWSVolume in the AWSNodePool object. This MR adds that field to the model.