OCM-2437 | feat: Expose /api/v1/clusters_mgmt/aws_inquiries/sts_account_roles #837
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
machi1990
reviewed
Sep 19, 2023
|
np: I don't know what happened but I am seeing 6 commits all having the same commit message. Can you squash them? |
Doh. Forgot to squash it. Thanks for the reminder 👍 |
machi1990
reviewed
Sep 20, 2023
robpblake
force-pushed
the
ocm-2437-sts-account-roles
branch
from
5d74a6a to
f266d61
Compare
|
All changes made @machi1990 👍 |
machi1990
reviewed
Sep 20, 2023
machi1990
reviewed
Sep 20, 2023
machi1990
approved these changes
Sep 20, 2023
There was a problem hiding this comment.
left one comment which will need others view on it as well.
Other than that the change looks good to me.
Thanks @robpblake
|
@oriAdler @andreadecorte PTAL |
ciaranRoche
approved these changes
Sep 20, 2023
oriAdler
reviewed
Sep 20, 2023
robpblake
force-pushed
the
ocm-2437-sts-account-roles
branch
from
f266d61 to
18ebcc4
Compare
|
/lgtm |
oriAdler
approved these changes
Sep 20, 2023
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates the API model to add support for the
/api/v1/clusters_mgmt/aws_inquiries/sts_account_rolesendpoint. The endpoint is already implemented, but is not exposed in the OpenAPI spec nor the SDK.