-
Notifications
You must be signed in to change notification settings - Fork 26
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
OCM-7117 | add capability of list resource with a scalar items
Issue: The LoadBalncerQuotaValues returns a list of scalar items. Because of this the metamodel started generating not valid sdk. Sample of the model: ``` resource LoadBalancerQuotaValues { method List { in out Page Integer = 1 in out Size Integer = 100 out Total Integer out Items []Integer } } ``` When generating the go sdk from teh model we get a error: ``` output/clustersmgmt/v1/load_balancer_quota_values_client.go:162:12: expected type, found '.' output/clustersmgmt/v1/load_balancer_quota_values_client.go:191:59: expected type, found '.' output/clustersmgmt/v1/load_balancer_quota_values_client.go:194:6: expected declaration, found '}' E: Can't format generated sources: exit status 2 ``` This is caused by the metamodel not handeling the list scalar items properly. Because the metamodel generates the reposnse struct and some other struct in following format: ``` type LoadBalancerQuotaValuesListResponse struct { status int header http.Header err *errors.Error items *.IntegerList page *int size *int total *int } ``` I have added a fix so it would generate the sdk structs with the list scalars. ``` // LoadBalancerQuotaValuesListResponse is the response for the 'list' method. type LoadBalancerQuotaValuesListResponse struct { status int header http.Header err *errors.Error items []int page *int size *int total *int } ``` Signed-off-by: Martin Necas <[email protected]>
- Loading branch information
Showing
5 changed files
with
81 additions
and
5 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
33 changes: 33 additions & 0 deletions
33
tests/model/clusters_mgmt/v1/load_balancer_quota_values_resource.model
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,33 @@ | ||
/* | ||
Copyright (c) 2024 Red Hat, Inc. | ||
|
||
Licensed under the Apache License, Version 2.0 (the "License"); | ||
you may not use this file except in compliance with the License. | ||
You may obtain a copy of the License at | ||
|
||
http://www.apache.org/licenses/LICENSE-2.0 | ||
|
||
Unless required by applicable law or agreed to in writing, software | ||
distributed under the License is distributed on an "AS IS" BASIS, | ||
WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
See the License for the specific language governing permissions and | ||
limitations under the License. | ||
*/ | ||
|
||
// Manages load balancer quota values. | ||
resource LoadBalancerQuotaValues { | ||
// Retrieves the list of Load Balancer Quota Values. | ||
method List { | ||
// Index of the requested page, where one corresponds to the first page. | ||
in out Page Integer = 1 | ||
|
||
// Number of items contained in the returned page. | ||
in out Size Integer = 100 | ||
|
||
// Total number of items of the collection. | ||
out Total Integer | ||
|
||
// Retrieved list of values. | ||
out Items []Integer | ||
} | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters