-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix tests #234
Fix tests #234
Conversation
Signed-off-by: clyang82 <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
In the modified file, I see some things done to the maestro/pkg/db/db_session/test.go Line 99 in 999e92a
maestro/pkg/db/db_session/test.go Line 87 in 999e92a
Plus some comments that are not actually true e.g maestro/pkg/db/db_session/test.go Line 94 in 999e92a
|
/assign @qiujian16 |
Signed-off-by: clyang82 <[email protected]>
I just realized that I should use |
I see comments referencing AMS, can we update them? |
Signed-off-by: clyang82 <[email protected]>
We have a question about why the CI passes without this fix, but the local environment does not. The reason is that in the CI environment, PostgreSQL runs in a sidecar container, making it effectively part of the same environment as the test container. In this case, no password is required for the database connection. The following explanation elaborates on this behavior.
from https://hub.docker.com/_/postgres