Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

save the spec to the status event when a resource is deleted #225

Merged
merged 1 commit into from
Dec 11, 2024

Conversation

skeeey
Copy link
Contributor

@skeeey skeeey commented Dec 9, 2024

No description provided.

@skeeey skeeey force-pushed the spec branch 2 times, most recently from a6a7bab to d5a6a58 Compare December 9, 2024 12:26
@skeeey skeeey changed the title keep the spec to the status event when a resource is deleted save the spec to the status event when a resource is deleted Dec 9, 2024
@skeeey skeeey force-pushed the spec branch 3 times, most recently from 6f4069c to 2a77173 Compare December 10, 2024 01:53
@skeeey
Copy link
Contributor Author

skeeey commented Dec 10, 2024

/assign @morvencao @clyang82 @qiujian16

Copy link
Contributor

@morvencao morvencao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me.

@clyang82
Copy link
Contributor

/ok-to-test

Copy link
Contributor

@clyang82 clyang82 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@clyang82
Copy link
Contributor

/retest

2 similar comments
@clyang82
Copy link
Contributor

/retest

@skeeey
Copy link
Contributor Author

skeeey commented Dec 10, 2024

/retest

@skeeey skeeey closed this Dec 11, 2024
@skeeey skeeey reopened this Dec 11, 2024
@skeeey
Copy link
Contributor Author

skeeey commented Dec 11, 2024

/retest

@skeeey skeeey force-pushed the spec branch 2 times, most recently from 2c087ea to d0a80c7 Compare December 11, 2024 01:49
@clyang82
Copy link
Contributor

/ok-to-test

Copy link
Contributor

@clyang82 clyang82 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@clyang82 clyang82 merged commit bc2f131 into openshift-online:main Dec 11, 2024
7 checks passed
machi1990 added a commit to Azure/ARO-HCP that referenced this pull request Dec 12, 2024
The following changes are included in the bump;

- ensure spec is returned in the status change event when a maestro bundle is being deleted (openshift-online/maestro#225)
- support entra auth for postgres (openshift-online/maestro#221)
- fix maestro agent resync unstable (openshift-online/maestro#220)
- register cloud events metrics(openshift-online/maestro#217)
- avoid nil point in go-sdk (openshift-online/maestro#212)
- update mqtt lib to resolve mqtt pinger problem (openshift-online/maestro#200)
- support print date in log (openshift-online/maestro#195)
- avoid race conditions on maestro-agent (openshift-online/maestro#196)
- use  orphan delete option as default option for read only update strategy (openshift-online/maestro#189)
@skeeey skeeey deleted the spec branch December 24, 2024 05:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants