support run e2e in rosa env #211
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/assign @clyang82 |
clyang82
reviewed
Oct 31, 2024
test/e2e/pkg/status_resync_test.go
Outdated
| Expect(err).ShouldNot(HaveOccurred()) | ||
| // In a ROSA cluster the sa in default namespace is protected, the sa cannot be deleted directly | ||
| // see https://access.redhat.com/solutions/7055600 | ||
| // err = agentTestOpts.kubeClientSet.CoreV1().ServiceAccounts("default").Delete(ctx, name, metav1.DeleteOptions{}) |
There was a problem hiding this comment.
Do we create the default serviceaccount? I think it should be there by default.
@morvencao comments?
There was a problem hiding this comment.
we assume default sa is there, it's not created by us.
the code change looks good to me, we can remove this.
There was a problem hiding this comment.
Thanks @morvencao
@skeeey Let us remove it directly
Signed-off-by: Wei Liu <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.