enhance log format using zapr logger. #195
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: morvencao <[email protected]>
morvencao
force-pushed
the
br_log_format
branch
from
625e24a to
6f47e44
Compare
|
/assign @qiujian16 @clyang82 @skeeey |
clyang82
reviewed
Oct 9, 2024
| @@ -24,18 +23,17 @@ func NewMigrationCommand() *cobra.Command { | |||
| } | |||
|
|
|||
| dbConfig.AddFlags(cmd.PersistentFlags()) | |||
| cmd.PersistentFlags().AddGoFlagSet(flag.CommandLine) | |||
There was a problem hiding this comment.
why do you remove it? We do not need it anymore?
There was a problem hiding this comment.
the flags is added into root command, so that all sub comands can share it.
| flags.SetNormalizeFunc(utilflag.WordSepNormalizeFunc) | ||
| flags.AddGoFlagSet(flag.CommandLine) |
There was a problem hiding this comment.
where is to configure the logs if you remove it in agent?
There was a problem hiding this comment.
the flags are added into the root command, we can still configure them when we run sub command(maestro migrate/server/agent).
|
/ok-to-test |
machi1990
added a commit
to Azure/ARO-HCP
that referenced
this pull request
Dec 12, 2024
The following changes are included in the bump; - ensure spec is returned in the status change event when a maestro bundle is being deleted (openshift-online/maestro#225) - support entra auth for postgres (openshift-online/maestro#221) - fix maestro agent resync unstable (openshift-online/maestro#220) - register cloud events metrics(openshift-online/maestro#217) - avoid nil point in go-sdk (openshift-online/maestro#212) - update mqtt lib to resolve mqtt pinger problem (openshift-online/maestro#200) - support print date in log (openshift-online/maestro#195) - avoid race conditions on maestro-agent (openshift-online/maestro#196) - use orphan delete option as default option for read only update strategy (openshift-online/maestro#189)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ref: https://issues.redhat.com/browse/ACM-14209
This PR introduces the following changes:
glogwithklogNote: Maestro still indirectly depends on
glogdue to the current dependencies ongithub.com/openshift-online/ocm-sdk-goandgithub.com/openshift-online/ocm-common, which useglog.klogto usezapras the backing logger.This setup enables enhanced logging features, including detailed timestamps and structured log output (e.g.,
JSONformat).Before this PR:
After this PR: