add aro-hcp scalability test #171
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
skeeey
force-pushed
the
perf
branch
2 times, most recently
from
16f2e45 to
5626269
Compare
clyang82
reviewed
Aug 13, 2024
|
|
||
| subscription_id="1d3378d3-5a3f-4712-85a1-2485495dfc4b" | ||
| resource_groups="aro-hcp-svc-cluster-cloud-user" | ||
| assignee="[email protected]" |
There was a problem hiding this comment.
those are credentials. you may pass them via environment variables.
There was a problem hiding this comment.
using env var instead
| @@ -0,0 +1,123 @@ | |||
| apiVersion: apiextensions.k8s.io/v1 | |||
There was a problem hiding this comment.
can we use https://github.com/open-cluster-management-io/api/blob/bd6f2229b53cb61c76ebf528c73bc925d8e0f4c8/work/v1/0000_01_work.open-cluster-management.io_appliedmanifestworks.crd.yaml instead of include it in maestro?
There was a problem hiding this comment.
apply them from ocm directly
| tokenConfig: {} | ||
| controllerAvailabilityPolicy: HighlyAvailable | ||
| dns: | ||
| baseDomain: az.test.red-chesterfield.com |
There was a problem hiding this comment.
you may pass baseDomain as environment variable.
There was a problem hiding this comment.
using an env variable
clyang82
reviewed
Sep 5, 2024
.gitleaks.toml
Outdated
| @@ -0,0 +1,11 @@ | |||
| [allowlist] | |||
There was a problem hiding this comment.
Do we still need to introduce this file?
Signed-off-by: Wei Liu <[email protected]>
|
/ok-to-test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.