Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Exclude override-snapshot generateName from diff check #3355

Conversation

creydr
Copy link
Member

@creydr creydr commented Jan 21, 2025

Excluding the override-snapshot name from the diff check

@openshift-ci openshift-ci bot requested review from mgencur and rhuss January 21, 2025 13:59
Copy link
Contributor

openshift-ci bot commented Jan 24, 2025

@creydr: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/417-operator-e2e 0fcc2af link true /test 417-operator-e2e

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@creydr
Copy link
Member Author

creydr commented Jan 24, 2025

/assign @pierDipi @mgencur

@mgencur
Copy link
Contributor

mgencur commented Jan 27, 2025

/lgtm

@openshift-ci openshift-ci bot added the lgtm label Jan 27, 2025
Copy link
Contributor

openshift-ci bot commented Jan 27, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: creydr, mgencur

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@mgencur
Copy link
Contributor

mgencur commented Jan 27, 2025

The validate-lint check fails with:

func ServerlessDowngradeOperations(ctx *test.Context, glob environment.GlobalEnvironment) []pkgupgrade.Operation {
                                                        ^

But that's a left-over from previous PRs.

@creydr creydr merged commit cde48d1 into openshift-knative:main Jan 27, 2025
15 of 30 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants