-
Notifications
You must be signed in to change notification settings - Fork 69
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add branch label to generated override snapshots #3354
Add branch label to generated override snapshots #3354
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
only be aware, that this is labeled ATM with release-1.35 as the bump on main didn't complete yet
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: creydr, mgencur The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/override ? |
@mgencur: /override requires failed status contexts, check run or a prowjob name to operate on.
Only the following failed contexts/checkruns were expected:
If you are trying to override a checkrun that has a space in it, you must put a double quote on the context. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
/override "Generated files are committed" |
@mgencur: Overrode contexts on behalf of mgencur: Generated files are committed, Red Hat Konflux / serverless-operator-136-ec / pr group add_branch_override_snapshot, Red Hat Konflux / serverless-operator-136-ec / serverless-ingress-136, Red Hat Konflux / serverless-operator-136-ec / serverless-kn-operator-136, Red Hat Konflux / serverless-operator-136-ec / serverless-metadata-webhook-136, Red Hat Konflux / serverless-operator-136-ec / serverless-must-gather-136, Red Hat Konflux / serverless-operator-136-ec / serverless-openshift-kn-operator-136, Red Hat Konflux / serverless-operator-136-enterprise-contract / pr group add_branch_override_snapshot, Red Hat Konflux / serverless-operator-136-enterprise-contract / serverless-ingress-136, Red Hat Konflux / serverless-operator-136-enterprise-contract / serverless-kn-operator-136, Red Hat Konflux / serverless-operator-136-enterprise-contract / serverless-metadata-webhook-136, Red Hat Konflux / serverless-operator-136-enterprise-contract / serverless-must-gather-136, Red Hat Konflux / serverless-operator-136-enterprise-contract / serverless-openshift-kn-operator-136 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
9abf38c
into
openshift-knative:main
This helps with downstream automation. It needs to be clear for which branch/stream the override snapshot in Konflux is generated. Currently, we parse it from "labels.application" but it is error-prone.
Proposed Changes