Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add branch label to generated override snapshots #3354

Conversation

mgencur
Copy link
Contributor

@mgencur mgencur commented Jan 21, 2025

This helps with downstream automation. It needs to be clear for which branch/stream the override snapshot in Konflux is generated. Currently, we parse it from "labels.application" but it is error-prone.

Proposed Changes

@openshift-ci openshift-ci bot requested review from aliok and creydr January 21, 2025 12:44
Copy link
Member

@creydr creydr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

only be aware, that this is labeled ATM with release-1.35 as the bump on main didn't complete yet

Copy link
Contributor

openshift-ci bot commented Jan 21, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: creydr, mgencur

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@mgencur
Copy link
Contributor Author

mgencur commented Jan 27, 2025

/override ?

Copy link
Contributor

openshift-ci bot commented Jan 27, 2025

@mgencur: /override requires failed status contexts, check run or a prowjob name to operate on.
The following unknown contexts/checkruns were given:

  • ?

Only the following failed contexts/checkruns were expected:

  • Generated files are committed
  • Red Hat Konflux / serverless-operator-136-ec / pr group add_branch_override_snapshot
  • Red Hat Konflux / serverless-operator-136-ec / serverless-ingress-136
  • Red Hat Konflux / serverless-operator-136-ec / serverless-kn-operator-136
  • Red Hat Konflux / serverless-operator-136-ec / serverless-metadata-webhook-136
  • Red Hat Konflux / serverless-operator-136-ec / serverless-must-gather-136
  • Red Hat Konflux / serverless-operator-136-ec / serverless-openshift-kn-operator-136
  • Red Hat Konflux / serverless-operator-136-enterprise-contract / pr group add_branch_override_snapshot
  • Red Hat Konflux / serverless-operator-136-enterprise-contract / serverless-ingress-136
  • Red Hat Konflux / serverless-operator-136-enterprise-contract / serverless-kn-operator-136
  • Red Hat Konflux / serverless-operator-136-enterprise-contract / serverless-metadata-webhook-136
  • Red Hat Konflux / serverless-operator-136-enterprise-contract / serverless-must-gather-136
  • Red Hat Konflux / serverless-operator-136-enterprise-contract / serverless-openshift-kn-operator-136
  • Update deps
  • ci/prow/417-images
  • ci/prow/417-operator-e2e
  • ci/prow/417-test-upgrade
  • ci/prow/417-upstream-e2e
  • ci/prow/417-upstream-e2e-kafka
  • code/snyk (Hybrid Platforms - OpenShift Serverless)
  • license/snyk (Hybrid Platforms - OpenShift Serverless)
  • pull-ci-openshift-knative-serverless-operator-main-417-images
  • pull-ci-openshift-knative-serverless-operator-main-417-operator-e2e
  • pull-ci-openshift-knative-serverless-operator-main-417-test-upgrade
  • pull-ci-openshift-knative-serverless-operator-main-417-upstream-e2e
  • pull-ci-openshift-knative-serverless-operator-main-417-upstream-e2e-kafka
  • security/snyk (Hybrid Platforms - OpenShift Serverless)
  • tide

If you are trying to override a checkrun that has a space in it, you must put a double quote on the context.

In response to this:

/override ?

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@mgencur
Copy link
Contributor Author

mgencur commented Jan 27, 2025

/override "Generated files are committed"
/override "Red Hat Konflux / serverless-operator-136-ec / pr group add_branch_override_snapshot"
/override "Red Hat Konflux / serverless-operator-136-ec / serverless-ingress-136"
/override "Red Hat Konflux / serverless-operator-136-ec / serverless-kn-operator-136"
/override "Red Hat Konflux / serverless-operator-136-ec / serverless-metadata-webhook-136"
/override "Red Hat Konflux / serverless-operator-136-ec / serverless-must-gather-136"
/override "Red Hat Konflux / serverless-operator-136-ec / serverless-openshift-kn-operator-136"
/override "Red Hat Konflux / serverless-operator-136-enterprise-contract / pr group add_branch_override_snapshot"
/override "Red Hat Konflux / serverless-operator-136-enterprise-contract / serverless-ingress-136"
/override "Red Hat Konflux / serverless-operator-136-enterprise-contract / serverless-kn-operator-136"
/override "Red Hat Konflux / serverless-operator-136-enterprise-contract / serverless-metadata-webhook-136"
/override "Red Hat Konflux / serverless-operator-136-enterprise-contract / serverless-must-gather-136"
/override "Red Hat Konflux / serverless-operator-136-enterprise-contract / serverless-openshift-kn-operator-136"

Copy link
Contributor

openshift-ci bot commented Jan 27, 2025

@mgencur: Overrode contexts on behalf of mgencur: Generated files are committed, Red Hat Konflux / serverless-operator-136-ec / pr group add_branch_override_snapshot, Red Hat Konflux / serverless-operator-136-ec / serverless-ingress-136, Red Hat Konflux / serverless-operator-136-ec / serverless-kn-operator-136, Red Hat Konflux / serverless-operator-136-ec / serverless-metadata-webhook-136, Red Hat Konflux / serverless-operator-136-ec / serverless-must-gather-136, Red Hat Konflux / serverless-operator-136-ec / serverless-openshift-kn-operator-136, Red Hat Konflux / serverless-operator-136-enterprise-contract / pr group add_branch_override_snapshot, Red Hat Konflux / serverless-operator-136-enterprise-contract / serverless-ingress-136, Red Hat Konflux / serverless-operator-136-enterprise-contract / serverless-kn-operator-136, Red Hat Konflux / serverless-operator-136-enterprise-contract / serverless-metadata-webhook-136, Red Hat Konflux / serverless-operator-136-enterprise-contract / serverless-must-gather-136, Red Hat Konflux / serverless-operator-136-enterprise-contract / serverless-openshift-kn-operator-136

In response to this:

/override "Generated files are committed"
/override "Red Hat Konflux / serverless-operator-136-ec / pr group add_branch_override_snapshot"
/override "Red Hat Konflux / serverless-operator-136-ec / serverless-ingress-136"
/override "Red Hat Konflux / serverless-operator-136-ec / serverless-kn-operator-136"
/override "Red Hat Konflux / serverless-operator-136-ec / serverless-metadata-webhook-136"
/override "Red Hat Konflux / serverless-operator-136-ec / serverless-must-gather-136"
/override "Red Hat Konflux / serverless-operator-136-ec / serverless-openshift-kn-operator-136"
/override "Red Hat Konflux / serverless-operator-136-enterprise-contract / pr group add_branch_override_snapshot"
/override "Red Hat Konflux / serverless-operator-136-enterprise-contract / serverless-ingress-136"
/override "Red Hat Konflux / serverless-operator-136-enterprise-contract / serverless-kn-operator-136"
/override "Red Hat Konflux / serverless-operator-136-enterprise-contract / serverless-metadata-webhook-136"
/override "Red Hat Konflux / serverless-operator-136-enterprise-contract / serverless-must-gather-136"
/override "Red Hat Konflux / serverless-operator-136-enterprise-contract / serverless-openshift-kn-operator-136"

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@openshift-ci-robot
Copy link

/retest-required

Remaining retests: 0 against base HEAD cde48d1 and 2 for PR HEAD ce54ce9 in total

@openshift-merge-bot openshift-merge-bot bot merged commit 9abf38c into openshift-knative:main Jan 27, 2025
30 of 43 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants